Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend scalar X directives are lost #2509

Closed
LastDragon-ru opened this issue Feb 19, 2024 · 0 comments · Fixed by #2512
Closed

extend scalar X directives are lost #2509

LastDragon-ru opened this issue Feb 19, 2024 · 0 comments · Fixed by #2512

Comments

@LastDragon-ru
Copy link
Contributor

Describe the bug

The resulting directives for Scalar

scalar Scalar 
@scalar(class: "GraphQL\\Type\\Definition\\StringType")
@directive(location: "scalar")

extend scalar Scalar 
@directive(location: "extend")

will be

scalar Scalar 
@scalar(class: "GraphQL\\Type\\Definition\\StringType")
@directive(location: "scalar")

Meanwhile the graphql-php gives both (as it should be):

scalar Scalar
@scalar(class: "GraphQL\\Type\\Definition\\StringType")
@directive(
    location: "scalar"
)
@directive(
    location: "extend"
)

Expected behavior/Solution

Scalar should have all directives from extension nodes.

Steps to reproduce

  1. Create the schema with extend scalar X @directive
  2. Print it

Lighthouse Version

v6.33.0

@LastDragon-ru LastDragon-ru changed the title extend scalar X/`` directives are lost extend scalar X directives are lost Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant