Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMarkdownTextEdit changes font, and font size during Bold and Italic operations #335

Closed
nuttyartist opened this issue Sep 16, 2022 · 13 comments · Fixed by #528
Closed

QMarkdownTextEdit changes font, and font size during Bold and Italic operations #335

nuttyartist opened this issue Sep 16, 2022 · 13 comments · Fixed by #528
Labels
Milestone

Comments

@nuttyartist
Copy link
Owner

A user reported that our Markdown editor (QMarkdownTextEdit) changes font, and font size during Bold and Italic operations.

@pbek Is it due to a recent change?

image

Screen Shot 2022-09-16 at 2 15 52 PM

@pbek
Copy link

pbek commented Sep 16, 2022

Hm, not that I know of... Can you trace that back to a specific commit of QMarkdownTextEdit?

@kana800
Copy link

kana800 commented Sep 17, 2022

Hey there !
I got same issue with the new version of the Notes app. Let me know if you need any help with figuring it out.

Cheers!

@zjeffer
Copy link
Collaborator

zjeffer commented Oct 4, 2022

On my system, this issue doesn't happen with my qt6 fork (#386), but it does happen when launching the notes installed from the AUR (which obviously uses qt5)

@zjeffer
Copy link
Collaborator

zjeffer commented Oct 11, 2022

I found that the problem isn't that it changes the font size, but the problem is the bold and italic text are always at a fixed size. So resizing the text extremely small will result in something like this:

image

And making the text bigger:

image

As you can see, the bold and italic text are always the same size. Same thing with the font: always the same font, regardless of the settings.

@nuttyartist
Copy link
Owner Author

@zjeffer Good catch. Is it something with QMarkdownTextEdit?

@zjeffer
Copy link
Collaborator

zjeffer commented Oct 16, 2022

I haven't found the exact issue yet, but I noticed that even the headers don't seem to change size when resizing, but the font does change when changing to a different fontface. I will investigate further when I have more time.

@nuttyartist
Copy link
Owner Author

I haven't find the exact issue yet, but I noticed that even the headers don't seem to change size when resizing, but the font does change when changing to a different fontface. I will investigate further when I have more time.

Yes, I noticed the same, but only on Macs if I remember correctly. Did you test on another OS?

@zjeffer
Copy link
Collaborator

zjeffer commented Oct 18, 2022

I only tested on linux.

@nuttyartist
Copy link
Owner Author

I only tested on linux.

I don't remember noticing this behavior on Linux, but I'll test.

@averissimo
Copy link

averissimo commented Dec 13, 2022

This is an annoying bug on the dev branch that reduces readability

Peek 2022-12-13 11-41

@averissimo
Copy link

averissimo commented Dec 13, 2022

Nevermind my comment, it seemed like I made a mistake and was running an older version of note

Below is from dev. There is a slight difference in size, but it's probably due to the font

Peek 2022-12-13 11-50

@nuttyartist
Copy link
Owner Author

Hi, which operating system are you using?

You're mentioning a case that is not quite related to the current issue. But I do think that the font is a little bit off when styling code markdown on my machine as well.

Screen Shot 2022-12-13 at 12 19 03 PM

I think the problem is that the styled markdown font isn't affected by the overall font size that we set for the editor.

@averissimo
Copy link

averissimo commented Dec 13, 2022

I'm under Ubuntu on X11 compiled from source (at ec85126)

Too be honest, this is much better and the qt6 merge might have reduced the impact of a bug that exists. But I'm talking out of my arse as I'm not familiar with the codebase.

Peek 2022-12-13 13-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants