Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not shutdown machine on certain changes #74

Closed
walkamongus opened this issue Aug 1, 2019 · 4 comments · Fixed by #75
Closed

Do not shutdown machine on certain changes #74

walkamongus opened this issue Aug 1, 2019 · 4 comments · Fixed by #75

Comments

@walkamongus
Copy link

Is your feature request related to a problem? Please describe.
Nutanix supports hot-plugging for things like CPU and memory, but currently changing this will result in a VM reboot/interruption.

Describe the solution you'd like
Certain changes to the VM (CPU and memory) should not initiate a shutdown/reboot.

Describe alternatives you've considered
I don't think there is an alternative in this particular case.

@Jorge-Holgado
Copy link
Contributor

Jorge-Holgado commented Aug 6, 2019

Good afternoon,
I've done a little patch on the provider in my fork:
https://github.com/Jorge-Holgado/terraform-provider-nutanix

Options that will be hot-plug (always):

  • name
  • description
    Options hot-plug just when increasing it:
  • num_vcpus_per_socket
  • num_sockets
  • memory_size_mib

You're right with the function location and the poweroff option, but there are some issues that I think I've solved. Give it a try and tell me if you have any issue.

@marinsalinas
Copy link
Contributor

@Jorge-Holgado could you please open a PR with these changes?

@Jorge-Holgado
Copy link
Contributor

@marinsalinas : Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants