-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cluster datasource name #100
Merged
marinsalinas
merged 5 commits into
nutanix:master
from
yannickstruyf3:feature/cluster_datasource_name
Mar 19, 2020
Merged
Feature/cluster datasource name #100
marinsalinas
merged 5 commits into
nutanix:master
from
yannickstruyf3:feature/cluster_datasource_name
Mar 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
size/L
label
Mar 17, 2020
yannickstruyf3
force-pushed
the
feature/cluster_datasource_name
branch
from
March 18, 2020 21:55
7055b2c
to
06e04ec
Compare
@marinsalinas rebased master |
yannickstruyf3
force-pushed
the
feature/cluster_datasource_name
branch
2 times, most recently
from
March 19, 2020 08:30
540d954
to
9220f58
Compare
yannickstruyf3
force-pushed
the
feature/cluster_datasource_name
branch
from
March 19, 2020 13:10
9220f58
to
64a478b
Compare
marinsalinas
suggested changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done, just few comments.
yannickstruyf3
force-pushed
the
feature/cluster_datasource_name
branch
2 times, most recently
from
March 19, 2020 15:31
c263135
to
05d299d
Compare
marinsalinas
suggested changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the unnecessary logs please.
yannickstruyf3
force-pushed
the
feature/cluster_datasource_name
branch
3 times, most recently
from
March 19, 2020 16:25
f8cd089
to
81513b7
Compare
yannickstruyf3
force-pushed
the
feature/cluster_datasource_name
branch
from
March 19, 2020 16:51
81513b7
to
a324e1a
Compare
marinsalinas
approved these changes
Mar 19, 2020
yannickstruyf3
pushed a commit
to yannickstruyf3/terraform-provider-nutanix
that referenced
this pull request
Nov 9, 2021
…tasource_name Feature/cluster datasource name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my clients requested the possibility to search clusters by name via the data sources. This code adds this functionality to the existing data_source_nutanix_cluster.go file.
Acceptance test included.