Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cluster datasource name #100

Merged

Conversation

yannickstruyf3
Copy link
Collaborator

One of my clients requested the possibility to search clusters by name via the data sources. This code adds this functionality to the existing data_source_nutanix_cluster.go file.

Acceptance test included.

@ghost ghost added the size/L label Mar 17, 2020
@yannickstruyf3 yannickstruyf3 force-pushed the feature/cluster_datasource_name branch from 7055b2c to 06e04ec Compare March 18, 2020 21:55
@ghost ghost added size/XL and removed size/L labels Mar 18, 2020
@yannickstruyf3
Copy link
Collaborator Author

@marinsalinas rebased master

@yannickstruyf3 yannickstruyf3 force-pushed the feature/cluster_datasource_name branch 2 times, most recently from 540d954 to 9220f58 Compare March 19, 2020 08:30
@ghost ghost added size/L and removed size/XL labels Mar 19, 2020
@yannickstruyf3 yannickstruyf3 force-pushed the feature/cluster_datasource_name branch from 9220f58 to 64a478b Compare March 19, 2020 13:10
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, just few comments.

nutanix/data_source_nutanix_cluster.go Outdated Show resolved Hide resolved
nutanix/data_source_nutanix_cluster.go Show resolved Hide resolved
nutanix/data_source_nutanix_cluster.go Show resolved Hide resolved
nutanix/data_source_nutanix_cluster.go Outdated Show resolved Hide resolved
@yannickstruyf3 yannickstruyf3 force-pushed the feature/cluster_datasource_name branch 2 times, most recently from c263135 to 05d299d Compare March 19, 2020 15:31
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the unnecessary logs please.

nutanix/resource_nutanix_virtual_machine.go Outdated Show resolved Hide resolved
nutanix/resource_nutanix_virtual_machine.go Outdated Show resolved Hide resolved
@yannickstruyf3 yannickstruyf3 force-pushed the feature/cluster_datasource_name branch 3 times, most recently from f8cd089 to 81513b7 Compare March 19, 2020 16:25
@yannickstruyf3 yannickstruyf3 force-pushed the feature/cluster_datasource_name branch from 81513b7 to a324e1a Compare March 19, 2020 16:51
@marinsalinas marinsalinas merged commit daa37e6 into nutanix:master Mar 19, 2020
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
…tasource_name

Feature/cluster datasource name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants