Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add functionality for Windows specific Makefile targets #229

Closed
glover-chris opened this issue Apr 14, 2022 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request P1 Critical

Comments

@glover-chris
Copy link

Describe the request
There are more and more Windows users utilizing Calm DSL and the current Makefile "dev" target is specific to Linux/Darwin python installations. Windows Python has different OS paths for binaries.
Current behaviour
Running "make dev" fails for Windows users configuring DSL.
Expected behaviour
Running "make dev" should work on windows.

A possible workaroound could be something like as follows: this example merely shows the "dev" target but all occurences of "venv/bin" should use the ${VENV_PATH} variable within the Makefile targets.

ifeq ($(OS),Windows_NT)
VENV_PATH = venv/Scripts
else
ifeq ($(UNAME_S),Linux)
VENV_PATH = venv/bin
endif
ifeq ($(UNAME_S),Darwin)
VENV_PATH = venv/bin
endif
endif

dev:
# Setup our python3 based virtualenv
# This step assumes python3 is installed on your dev machine
[ -f ${VENV_PATH}/Scripts/python ] || (python -m venv venv &&
${VENV_PATH}/pip install --upgrade pip setuptools)
${VENV_PATH}/pip install --no-cache -r requirements.txt -r dev-requirements.txt
${VENV_PATH}/python setup.py develop

@glover-chris glover-chris added the enhancement New feature or request label Apr 14, 2022
@abhijeetkaurav1st abhijeetkaurav1st added the P1 Critical label Mar 17, 2023
@dwivediprab
Copy link
Collaborator

Fixed as part of DSL v4.0.0 release. Now we can use make windev to build DSL on windows machine.

@glover-chris
Copy link
Author

Thanks @dwivediprab !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Critical
Projects
None yet
Development

No branches or pull requests

3 participants