You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But that's not working, which looks pretty odd in some cases, primarily one-liners:
I think there are two reasons that line numbers aren't currently disabled:
First, when we switched to Shiki, the configuration option for turning off line numbers changed, and it wasn't updated in the config.
But more importantly, it looks like there's an upstream problem where the line number setting for the Shiki plugin is completely broken. Attempting to set lineNumbers: false or lineNumbers: disabled, even in the Shiki plugin options, results in line numbers for everything except the last line of a code block.
I've even tested this in a fresh Vuepress site unrelated to Nushell:
Of course, this appears to be an upstream issue, but I'm surprised something so fundamental could be
There's also an option to only turn on line-numbers when the code-block is more than x lines, but that is just as broken.
I'm wondering if there's a conflict between prismjs and Shiki, since the code-blocks (even on our site) still show both a div with a prismjs attribute and a separate pre block with a shiki attribute.
Anyway - If anyone knows what is going on here, feel free to chime in.
In the meantime, I'll look at other options, such as disabling for each block (still works) or doing it with custom CSS rules.
The text was updated successfully, but these errors were encountered:
Our current config for Vuepress is set for
lineNumbers: false
in the config.But that's not working, which looks pretty odd in some cases, primarily one-liners:
I think there are two reasons that line numbers aren't currently disabled:
First, when we switched to Shiki, the configuration option for turning off line numbers changed, and it wasn't updated in the config.
But more importantly, it looks like there's an upstream problem where the line number setting for the Shiki plugin is completely broken. Attempting to set
lineNumbers: false
orlineNumbers: disabled
, even in the Shiki plugin options, results in line numbers for everything except the last line of a code block.I've even tested this in a fresh Vuepress site unrelated to Nushell:
Of course, this appears to be an upstream issue, but I'm surprised something so fundamental could be
There's also an option to only turn on line-numbers when the code-block is more than
x
lines, but that is just as broken.I'm wondering if there's a conflict between prismjs and Shiki, since the code-blocks (even on our site) still show both a
div
with aprismjs
attribute and a separatepre
block with ashiki
attribute.Anyway - If anyone knows what is going on here, feel free to chime in.
In the meantime, I'll look at other options, such as disabling for each block (still works) or doing it with custom CSS rules.
The text was updated successfully, but these errors were encountered: