Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnu Coreutils - uucoreutils ls fix #41

Closed
alexkunde opened this issue May 22, 2023 · 1 comment
Closed

Gnu Coreutils - uucoreutils ls fix #41

alexkunde opened this issue May 22, 2023 · 1 comment

Comments

@alexkunde
Copy link

alexkunde commented May 22, 2023

Hi,
this crate is used via lscolors crate in the rust drop-in replacement for gnu coreutils called uucoreutils.
The original GNU util ls is still using some extended modes that are not supported by this crate.

  1. two-digit style codes -> Add feature: gnu_legacy mode for ansi styles #39
  2. reset prefix for any string -> Add resetted styling #40

To continue using this crate, it would really help to improve on those two topics. The added PRs will add both functionalities.
Both are using main branch, so I guess the second merge would need a rebase first.

After the merge, this GNU test will turn green:

OLD

FAIL: tests/ls/color-term
=========================

--- exp 2023-05-16 15:56:30.337121900 +0200
+++ out 2023-05-16 15:56:30.102644900 +0200
@@ -1,4 +1,4 @@
-^[[0m^[[01;32mexe^[[0m$
-^[[0m^[[01;32mexe^[[0m$
+^[[1;32mexe^[[0m$
+^[[1;32mexe^[[0m$
 exe$
 exe$
FAIL tests/ls/color-term.sh (exit status: 1)

After both PRs

SUCCESS: tests/ls/color-term
=========================
@@ -1,4 +1,4 @@
^[[0m^[[01;32mexe^[[0m$
^[[0m^[[01;32mexe^[[0m$
 exe$
 exe$
FAIL tests/ls/color-term.sh (exit status: 1)

Thanks for your help!

@alexkunde
Copy link
Author

Both features have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant