Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User guide did not say that index must be an integer but the error promted #1606

Open
nus-pe-bot opened this issue Nov 16, 2019 · 1 comment

Comments

@nus-pe-bot
Copy link

Screenshot 2019-11-15 at 5.14.36 pm.png

Screenshot 2019-11-15 at 5.14.44 pm.png

I typed this :
routeList 1.0


[original: nusCS2113-AY1920S1/pe-interim#1620]
@Jefferson111
Copy link
Contributor

Jefferson111 commented Nov 17, 2019

Team's Response

I believe the general consensus is that index refers to an Integer. This is clearly not a functionality bug in any way.

Moreover, we did mentioned in our UG that we should interpret index as a positive integer.

If anything, this seems to be the case of user expectation, where the user thinks that being able to input in a number that has a decimal point will work.

It would not make sense in any way to show the route at index 1.0 as an example.

What if we were to show the route at index 1.1 instead? That would not make sense at all.

It would be a functionality bug if we instead allowed decimals like "1.0", because it will be questionable to allow the user to input such values and have the command actually work.

You are clearly trying to break the program and it didn't break. How is this even a bug?
ಠ_ಠ

Changed this to severity.Low as it is a nonsensical issue. It does not even affect anything in the application.

A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

image.png

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants