Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Syntax highlighting on the unit testing FAQ page makes the code illegible #194 #195

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

spaghetti-
Copy link
Contributor

This prevents the CSS background color for code leaking into the sunburst prettifier theme.

This fixes #194

screen shot 2016-11-25 at 3 08 44 pm

@acjh
Copy link
Collaborator

acjh commented Nov 25, 2016

Nice fix! Take note of the guidelines for naming PRs:

The branch name should be in the format issue-number-some-key-words i.e. issue number followed by 2-4 key words related to the issue description e.g. 194-syntax-highlighting-code-illegible

When naming the PR, copy paste the name of the issue you are fixing, including the original issue number. e.g. Syntax highlighting on the unit testing FAQ page makes the code illegible #194

@spaghetti- spaghetti- changed the title Fix css selector for code leaking into the sunburst code prettifier rule Syntax highlighting on the unit testing FAQ page makes the code illegible #194 Nov 25, 2016
@spaghetti-
Copy link
Contributor Author

@acjh thanks, I was just fixing it as I was reading through the coursework and forgot to follow the pr guidelines (especially branch name). Do you need me to resubmit the PR?

@damithc
Copy link
Contributor

damithc commented Nov 25, 2016

We can overlook the wrong branch name for the fist PR of a new contributor :-)

@acjh
Copy link
Collaborator

acjh commented Dec 6, 2016

@damithc Shall I merge this?

@damithc
Copy link
Contributor

damithc commented Dec 6, 2016

Sure @acjh . Use 'squash and merge' option.

@acjh acjh merged commit 61fafde into nus-cs2103:master Dec 6, 2016
@spaghetti- spaghetti- deleted the css-patch1 branch December 7, 2016 01:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting on the unit testing FAQ page makes the code illegible
3 participants