Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCaseSource now ignore all classes derived from TestCaseParameters #524

Merged
merged 1 commit into from
Feb 22, 2023
Merged

TestCaseSource now ignore all classes derived from TestCaseParameters #524

merged 1 commit into from
Feb 22, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #523

mikkelbu
mikkelbu approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A little odd that Roslyn don't have an inbuilt IsOrDerivesFrom, but the implementation is as expected.

@mikkelbu mikkelbu merged commit a3b4672 into nunit:master Feb 22, 2023
@mikkelbu mikkelbu added this to the Release 3.7 / 2.7 milestone Feb 22, 2023
@manfred-brands manfred-brands deleted the issue523_TestCaseData branch February 22, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.6.1 / 2.6.1
Development

Successfully merging this pull request may close these issues.

False positive for NUnit1030 with TestCaseParameters
2 participants
@manfred-brands @mikkelbu