Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for use by the .NET Core runner #61

Closed
CharliePoole opened this issue Jun 8, 2024 · 2 comments · Fixed by #62
Closed

Add support for use by the .NET Core runner #61

CharliePoole opened this issue Jun 8, 2024 · 2 comments · Fixed by #62
Assignees
Labels
Milestone

Comments

@CharliePoole
Copy link
Collaborator

Package will need to include either a .NET Standard or .NET Core build.

@CharliePoole CharliePoole self-assigned this Jun 8, 2024
@CharliePoole CharliePoole added this to the 3.8 milestone Jun 8, 2024
@CharliePoole
Copy link
Collaborator Author

There are two ways to handle this:

  1. First fix Multi-targeted Engine Extensions nunit-console#394, which may require a bit of work.
  2. Provide an adhoc fix, by creating a second, separate package NUnit.Extension.NetStandardProjectLoader.

For 4.X, I think option 1 is preferable, for 3.18.0, I think either one is good but option 1 does avoid the problem of proliferating extensions we would probably end up deprecating in V4.

Although Chris and I spent a lot of time discussing the options for nunit/nunit-console#394, I need to review the code in detail to decide how difficult a change it is. If it's not too bad, that would be my preference.

@OsirisTerje Any thoughts on this? Since both the netcore runner and the adapter run tests in the existing process, I'm assuming that what works for one will work for the other.

@CharliePoole
Copy link
Collaborator Author

I've gone with option 1, fixing nunit/nunit-console#394. The nunit project loader extension is now multi-targeted to .NET Framework 2.0 and Net Standard 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant