Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests of .NET Core 3.1 packages #852

Closed
CharliePoole opened this issue Jan 2, 2021 · 2 comments · Fixed by #883
Closed

No tests of .NET Core 3.1 packages #852

CharliePoole opened this issue Jan 2, 2021 · 2 comments · Fixed by #883
Assignees
Labels
Milestone

Comments

@CharliePoole
Copy link
Member

When the .NET Core 3.1 package was added, no checks were added to package-checks.cake. The package checks aren't real tests but they at least confirm that the right files are in each package, avoiding the need for manual verification.

@CharliePoole
Copy link
Member Author

I believe this also applies to the .NET Core console package.

@CharliePoole CharliePoole self-assigned this Jan 28, 2021
@CharliePoole CharliePoole added this to the 3.13 milestone Jan 28, 2021
@CharliePoole
Copy link
Member Author

@ChrisMaddock I'll go ahead and do this as it's simple. I put it in the 3.13 milestone. I assume we'll eventually decide whether to actually have a 3.13 or to just put these changes into 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants