Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine should honor the DOTNET_ROOT environment variable if set #1381

Closed
Tracked by #1547
MichalMucek opened this issue Jan 11, 2024 · 4 comments · Fixed by #1495
Closed
Tracked by #1547

Engine should honor the DOTNET_ROOT environment variable if set #1381

MichalMucek opened this issue Jan 11, 2024 · 4 comments · Fixed by #1495
Assignees
Labels
Milestone

Comments

@MichalMucek
Copy link

Add a parameter to NUnit Console for .NET installation/binaries directory path that, when defined, will omit or extend NUnit.Engine.Internal.TestAssemblyResolver.GetDotNetInstallDirectory().

The motivation behind this feature is to enable the NUnit Console to work in Windows environments where .NET is not installed but only .NET binaries are downloaded, e.g. during pipeline execution.

@stevenaw
Copy link
Member

@MichalMucek Are the binaries used in your pipeline for net framework or core/net5+?

For the latter, I think the DOTNET_ROOT environment variable would be the standard way to define this if the console runner were updated to support this (https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-environment-variables#dotnet_root-dotnet_rootx86).

@CharliePoole
Copy link
Member

@MichalMucek Rather than adding a command-line option, I'm inclined to use @stevenaw 's suggestion and honor any of the DOTNET_ROOT environment variables. Does that work for you?

@CharliePoole CharliePoole self-assigned this Sep 30, 2024
@CharliePoole CharliePoole added this to the 3.18.3 milestone Sep 30, 2024
@MichalMucek
Copy link
Author

@stevenaw core/net5+

@CharliePoole Sounds good

@CharliePoole CharliePoole changed the title Add parameter for .NET installation/binaries directory path Engine should honor the DOTNET_ROOT environment variable Oct 2, 2024
@CharliePoole CharliePoole changed the title Engine should honor the DOTNET_ROOT environment variable Engine should honor the DOTNET_ROOT environment variable if set Oct 2, 2024
@CharliePoole
Copy link
Member

This issue has been resolved in version 3.18.3

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants