-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align behavior of pre-commit hook and Sphinx extension #476
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
51bcea6
Extract check selection logic from sphinx side into utility function.
stefmolin 61b83cf
Add test cases for get_validation_checks().
stefmolin 5a4c88b
Change pre-commit hook behavior from check exclusion to check selecti…
stefmolin 729e563
Update example configs for pre-commit hook in docs.
stefmolin 4c3b90f
Add global exclusion option to pre-commit hook.
stefmolin cd4316c
Add test cases for global exclusion pre-commit option.
stefmolin 8a88bda
Update docs for global exclusion option.
stefmolin 4a6c2ec
Deprecate override_GL08 since global exclusion covers this.
stefmolin ff8db01
Expand override logic for pre-commit hook to any check.
stefmolin 4372122
Update override examples in docs.
stefmolin 06049e2
Check for exclusion before running checks.
stefmolin bb311e8
Port inline comments for ignoring checks to sphinx side.
stefmolin e857c12
Move note in docs on inline comments to its own section now that both…
stefmolin 6733384
Remove ignore comment logic from hook now that it is in validate().
stefmolin 3c30699
Add note on inline comment usage for --validate.
stefmolin e593a10
Add numpydoc_validation_overrides option to Sphinx extension side.
stefmolin ddb7b49
Add numpydoc_validation_overrides option to the docs.
stefmolin 40269ba
Refine additions to docs.
stefmolin 33db266
Clarify comment.
stefmolin 3f92758
Switch to typing for Python 3.8
stefmolin 76f265b
Fix check on type.
stefmolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always found the numpydoc convention confusing; I think the exclusion list you had before is more logical.