Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: work around GH isaacs/github#316 to show SVG image #11003

Merged
merged 1 commit into from
May 5, 2018

Conversation

mattip
Copy link
Member

@mattip mattip commented Apr 29, 2018

There is an issue with the way github renders SVG images in README files, isaacs/github#316

Fixes #11000

@eric-wieser
Copy link
Member

Didn't realize that rawgithub.com changed its name. This looks like a pretty reasonable solution to me.

That issue's awfully old though, and this problem is recent for us - I do wonder if this is just a temporary glitch on github's side.

@mattip
Copy link
Member Author

mattip commented Apr 29, 2018

We could wait a week before merging

@charris
Copy link
Member

charris commented May 5, 2018

Man, that's weird. The page rendering changes every time I check out numpy/numpy, but looks mostly decent if I check out the README.md file. Anyway, let's give this a shot, it seems that other projects are still using this fix.

Thanks Matti.

@charris charris merged commit 65968fb into numpy:master May 5, 2018
@charris
Copy link
Member

charris commented May 5, 2018

Maybe Github is just getting slow ...

@mattip mattip deleted the readme-image branch May 7, 2018 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants