Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working in Nightly 2024-08-22 #113

Closed
sinyb opened this issue Aug 23, 2024 · 30 comments · May be fixed by #116
Closed

Stopped working in Nightly 2024-08-22 #113

sinyb opened this issue Aug 23, 2024 · 30 comments · May be fixed by #116

Comments

@sinyb
Copy link

sinyb commented Aug 23, 2024

Describe the bug
Since Nightly 131.0a1 (2024-08-22) there are no more multiple rows, only one row is displayed, but I can go to other tabs with Ctrl-PgUp/PgDn

Environment
OS Linux (opensuse, current) and Windows 10, Firefox Nightly 131.0a1 (2024-08-22+), Paxmod version 3.16

@GIS1980
Copy link

GIS1980 commented Aug 24, 2024

@sinvb - happened for me also.
"You don't know what you got 'til it's gone".

@gammy
Copy link

gammy commented Aug 25, 2024

Same here but a different date:
Firefox 131.0a1 (2024-08-24) (64-bit),
Paxmod 3.16 (April 28, 2024)
Debian trixie (testing), but I suspect that's irrelevant.

Paxmod is still active and running; color attributes and fixed-width is still there, but not multi-row tabs. It seems it also breaks the stock firefox behavior (not too surprising) in that I can only see the top row of tabs (but not the rest). Pinned tabs are not visible.

@Wolferine69
Copy link

same here..anybody have solution?

@sinyb
Copy link
Author

sinyb commented Aug 26, 2024

"Solutions" for now are:

  1. DON'T restart Nightly when asked to - will keep you OK until you first have to reboot
  2. run Firefox Dev and open tabs from Nightly session (you have set up Firefox account between two, right? So you can switch to something at least half-stable when bleeding-edge goes south... not that I remember when did I have to, but this is a good opportunity)

:)

@Wolferine69
Copy link

workaround - downgrade FF and disable automatic updates, profile can be reused after downgrade, just delete compatibility.ini from it

@gammy
Copy link

gammy commented Aug 27, 2024

workaround - downgrade FF and disable automatic updates, profile can be reused after downgrade, just delete compatibility.ini from it

Asking just for clarity: to which version is one to downgrade, and where would one obtain said version?

@huh666
Copy link

huh666 commented Aug 27, 2024

i try firefox-131.0a1.en-US.win64.installer.exe from here: https://ftp.mozilla.org/pub/firefox/nightly/2024/08/2024-08-21-16-06-37-mozilla-central/ and it works, dont forget before disable "Automatically install updates (recommended)" in settings menu

@Wolferine69
Copy link

workaround - downgrade FF and disable automatic updates, profile can be reused after downgrade, just delete compatibility.ini from it

Asking just for clarity: to which version is one to downgrade, and where would one obtain said version?

I am using https://ftp.mozilla.org/pub/firefox/nightly/2024/07/2024-07-09-21-41-33-mozilla-central-l10n/firefox-130.0a1.cs.win64.installer.exe (czech version)

@GIS1980
Copy link

GIS1980 commented Aug 27, 2024

When I turn Paxmod on, I get the following message in the browser console. Unsure if it points to anything meaningful:

Unexpected pre-existing callContextData on ""Paxmod" (ID: paxmod@numirias, moz-extension://02f72ee3-243a-476a-a1bd-4676f5a011f0/)" contextId 455

@by-shiw
Copy link

by-shiw commented Sep 1, 2024

i try firefox-131.0a1.en-US.win64.installer.exe from here: https://ftp.mozilla.org/pub/firefox/nightly/2024/08/2024-08-21-16-06-37-mozilla-central/ and it works, dont forget before disable "Automatically install updates (recommended)" in settings menu

it worked on mac, thanks.

@alen-z
Copy link

alen-z commented Sep 3, 2024

Stopped on Developer Edition.

@sinyb
Copy link
Author

sinyb commented Sep 4, 2024

Stopped on Developer Edition.

Thanks, read this just in time to prevent my Dev from updating.

@alen-z
Copy link

alen-z commented Sep 4, 2024

My new approach is as follows.

userChrome.css

/* 2024-11 */
toolbar#TabsToolbar {
    display: none;
}

/* old */

vbox#titlebar {
    display: none;
}

Add sidebar with Simple Tab Groups plugin.

image

Edit:

  • Use FF UI debugging mode.
  • In active root profile directory found in about:profiles, place file in /chrome/userChrome.css.

@corang
Copy link

corang commented Sep 4, 2024

Yeah, confirm stopped working in dev firefox :(

@adisor19
Copy link

adisor19 commented Sep 4, 2024

Crap.. i really hope there is a fix for this. I need multiple rows of tabs

@corang
Copy link

corang commented Sep 5, 2024

Once you downgrade you can add a policies.json file in a folder called distribution next to firefox.exe that keeps it from asking you to update:

{
    "policies": {
        "AppAutoUpdate": false,
        "AppUpdatePin": "131.",
        "BackgroundAppUpdate": false,
        "DisableAppUpdate": true,
        "ManualAppUpdateOnly": true
    }
}

file structure:

- firefox.exe
- distribution
   |- policies.json

only tested on windows with firefox nightly

@adisor19
Copy link

adisor19 commented Sep 7, 2024

Unfortunately, the blocker does not work on macOS with the FireFox Dev edition.. It updates automatically upon restart of Firefox.. If anyone knows how to block it from updating, please share..

@adisor19
Copy link

adisor19 commented Sep 7, 2024

UPDATE: I disabled automatic updates and I was able to keep it on Firefox 130.0b9 indefinitly after multiple restarts. In order to downgrade the profile, I was able to do it by starting up 130.0b9 from terminal with this command : cd /Applications/Firefox\ Developer\ Edition.app/Contents/MacOS followed by ./firefox -allow-downgrade

@fraynaud33
Copy link

fraynaud33 commented Sep 9, 2024

Hello, I found tab mix plus is reborn !!!
https://github.com/onemen/TabMixPlus
But this project seems to be more maintained. (last update 08/09/2024 !)
But unfortunately It doesn't work on Firefox 131.0b too ;-(
I create an issue, we will see what happen.

Edit 10/09/2024 : the release123 fix the bug and multi row works now on 131.0b4 !

@Olddddd
Copy link

Olddddd commented Sep 13, 2024

Hello, I found tab mix plus is reborn !!! https://github.com/onemen/TabMixPlus But this project seems to be more maintained. (last update 08/09/2024 !) But unfortunately It doesn't work on Firefox 131.0b too ;-( I create an issue, we will see what happen. Edit 10/09/2024 : the release123 fix the bug and multi row works now on 131.0b4 !

But no dynamic color unfortunately. We can still combine both extensions but there are few bugs in doing so.

@tauon
Copy link

tauon commented Sep 14, 2024

When I turn Paxmod on, I get the following message in the browser console. Unsure if it points to anything meaningful:

Unexpected pre-existing callContextData on ""Paxmod" (ID: paxmod@numirias, moz-extension://02f72ee3-243a-476a-a1bd-4676f5a011f0/)" contextId 455

Looks like this is the line that's getting hit: https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionParent.sys.mjs#656

@nazar-pc
Copy link

Here is how it was fixed in the extension above: onemen/TabMixPlus@21288e5

@inthroxify
Copy link

inthroxify commented Sep 17, 2024

Hello, I found tab mix plus is reborn !!! https://github.com/onemen/TabMixPlus But this project seems to be more maintained. (last update 08/09/2024 !) But unfortunately It doesn't work on Firefox 131.0b too ;-( I create an issue, we will see what happen. Edit 10/09/2024 : the release123 fix the bug and multi row works now on 131.0b4 !

@fraynaud33 Thank you for finding this and posting here! I could kiss you, I am so happy to see that TMP is still around, I had no idea. I am switching.

@numirias Are you still around?

@nazar-pc
Copy link

He responded to me last time about 2 years ago on Twitter, but nothing since unfortunately

@parasiteoflife
Copy link

Someone please make a fork, numirias has not shown public activity for 2 years

@nazar-pc
Copy link

nazar-pc commented Oct 4, 2024

Looks like it broke even more than before in latest nightly making this extension unusable for me.

https://github.com/MrOtherGuy/firefox-csshacks/blob/master/chrome/multi-row_tabs.css allows to bring back multi-row-tabs, but not other things. @MrOtherGuy's collection of tweaks is quite extensive and I think they'd be able to fix our issues here, but not sure they have the time or passion for it.

@MrOtherGuy
Copy link

I'll jump in to say that no, I don't have any interest in maintaining this project, but I can give you some pointers.

I'm pretty sure that the problem that first caused this issue on 2024-08-22 is that your browser.css line 43 doesn't apply the rules to the correct element anymore. Those style rules should be applied to the child <slot> of that element. Unfortunately the way you have set things up (because your browser.css is loaded as author sheet) you cannot target that <slot> element. If you went to change your browser.css to be loaded as user_sheet instead, the you would need to rewrite bunch of other things. Another option, although I'm not sure if that is available for you, would be to mark that slot element with a part attribute, which you could then use in browser.css in place of that ::part(scrollbox) (could be for example ::part(scrollbox-slot) or whatever).

I don't know your project well enough to tell what broke just now in Nightly 133, but the #titlebar was wholly removed if any part of your codebase rely on that element being there then it will certainly be broken.

@aadityaverma
Copy link

Still Broken in Dev Ubuntu.

@sinyb
Copy link
Author

sinyb commented Nov 5, 2024

Well, I have switched to MrOtherGuy's "firefox-csshacks" https://github.com/MrOtherGuy/firefox-csshacks/tree/master just to have back multi-row tabs, and it is working fine in latest Nightly. Yes, I am missing a few good things from here (differrent colors for example), but I only really need multiple rows of tabs, everything else is not so important.
I am closing this now as "won't fix, go elsewhere"

@sinyb sinyb closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
@adisor19
Copy link

adisor19 commented Nov 5, 2024

That's shame as this is honestly the better addon out there.. Oh well. Maybe one day, @numirias will surprise us all with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.