fix condition of combining edge points #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #39 +/- ##
=======================================
Coverage 51.03% 51.03%
=======================================
Files 10 10
Lines 1354 1354
=======================================
Hits 691 691
Misses 663 663
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kunyuan
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that causes error when constructing log densed grids.
Old constructor of LDG combine two panel points only when p[2]-p[1]<minterval, and this leads to construction of Log grids with bound[2]-bound[1]==minterval, which will be rejected by the recently updated assertion 0<minterval<bound[2]-bound[1].
The condition is adjusted to p[2]-p[1]<=2minterval, which still guarantees minimal interval is smaller than minterval, while eliminates cases with too small interval.