Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Network action result url should display asset profile link instead of direct iframe prod link #180

Closed
sync-by-unito bot opened this issue Nov 24, 2022 · 4 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 24, 2022

Your email:
[email protected]

Select product:
Capture App

One line to describe the issue you see or the feature you want to add:
[Need discuss] Network action result url should display asset profile link or direct iframe prod link?

Let us know what do you expect to see?:
The result url should display nse asset profile or iframe link direct.

Please provide some simple steps to help us reproduce the issue or understand how do you want to see the feature.:

  1. choose an asset
  2. operate network action "mint & share"
  3. when process finish, go to activity -> network action
  4. press the record you have operated, will see the result url

What's the device or browser do you use?:
All device will happened this

———————————————
This task was submitted through Issue Report/Feature Request
https://form.asana.com/?k=OlNjzNIasZt0uOT5gzb7pw&d=1200886955782960

┆Issue is synchronized with this Asana task by Unito

@sync-by-unito sync-by-unito bot changed the title [Need discuss] Network action result url should display asset profile link or direct iframe prod link? [FR] Network action result url should display asset profile link instead of direct iframe prod link Nov 24, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 24, 2022

➤ Kenny Hung commented:

Tammy Yang (cc Sam ) This task needs your confirmation.
About the mint & share network action, do we display the iframe URL or nse asset profile link?
If we still use iframe URL, and this task could be close.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 24, 2022

➤ Tammy Yang commented:

Asset profile

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, can you check this claap ( https://app.claap.io/numbers-protocol/fr-network-action-result-url-should-display-asset-profile-link-instead-of-direct-iframe-prod-link-c-O35CsUM4Uy-PGgmf5_QjIeF ) is it expected to change? If yes I will submit it for code review (PR ( numbersprotocol/capture-lite#2336 )).

@sync-by-unito sync-by-unito bot closed this as completed Nov 25, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Sam yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants