Build bump to 0.54.2 #1540

sultanmyrza · 2022-04-22T07:02:47Z

No description provided.

…ra-ux" This reverts commit 3aa077f, reversing changes made to 11c83e6.

imported SharedTestingModule in TestBed

shc261392

Looks good to me.

shc261392 · 2022-04-22T08:04:43Z

Discussion for preview-video plugin
https://dt42-numbers.slack.com/archives/C0323488MEJ/p1650612388174209
https://dt42-numbers.slack.com/archives/C0323488MEJ/p1650614603596759

[capture-lite]
We can choose from either

Disable the component test in tsconfig.spec.json by adding "exclude": ["src/<path-to-the-file>/go-pro-media-viewer-with-native-player.component.ts"]
Inside GoProMediaViewerWithNativePlayerComponent, check platform before calling any functions from preview-video plugin. If it is web, don’t call any unimplemented functions from preview-video.

[preview-video]
The previous change can be reverted.

sultanmyrza added 4 commits April 22, 2022 11:20

Revert "Merge pull request #1523 from sultanmyrza/feature-custom-came…

8fe89fb

…ra-ux" This reverts commit 3aa077f, reversing changes made to 11c83e6.

build: bump version to 0.54.2

fd354d1

fix(go-pro-media-viewer-with-native-player.component.spec):

00c28e2

imported SharedTestingModule in TestBed

install latest preview-video plugin to pass test.ci

d474430

shc261392 approved these changes Apr 22, 2022

View reviewed changes

shc261392 merged commit f765b10 into develop Apr 22, 2022

sultanmyrza deleted the build-bump-to-0.54.2 branch June 11, 2022 02:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build bump to 0.54.2 #1540

Build bump to 0.54.2 #1540

sultanmyrza commented Apr 22, 2022

shc261392 left a comment

shc261392 commented Apr 22, 2022

Build bump to 0.54.2 #1540

Build bump to 0.54.2 #1540

Conversation

sultanmyrza commented Apr 22, 2022

shc261392 left a comment

Choose a reason for hiding this comment

shc261392 commented Apr 22, 2022