Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] If user choose they are not creator, that asset doesn't shown on recently upload #3109

Closed
sync-by-unito bot opened this issue Nov 27, 2023 · 12 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 27, 2023

User story

Reproduce step

  1. Upload asset
  2. close claim creator toggle
  3. Uploading finish
  4. Go to Dashboard main page, see the recently assets, can't see that one

Expectation

Additional information:

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Ethan Wu commented:

Kenny Hung my question is: is this expected behavior.

there is a parameter in storage backend - get media called is_original_owner which is being leveraged to do filter out the created assets.

if the user is not the creator than it shouldn't appear.

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Ethan Wu commented:

Tammy Yang i have provided comment on the claap but i believe the single api call (no filter) than leverage bubbles filtered has limitations.

after discussing with Scott Yan we have determined we can use the "sourceType" parameter to filter out all created assets (regardless of whether or not claim creator was toggled on or off)

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Ethan Wu commented:

Tammy Yang for now will be leveraging sourceType : original to fix this issue.

@sync-by-unito sync-by-unito bot closed this as completed Nov 27, 2023
Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Ethan Wu commented:

will need to do some testing to ensure that "suggested" implementation has no issues.

currently i think there are limitations:

  • for accounts that have more than 200 assets => pulling all information will no filters may result in incorrect information because storage backend returns 200 results at a time. if filters apply for assets outside of that initial 200 asset response than it will not appear. (will need to test to confirm)

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Ethan Wu commented:

created task for tracking purposes: [performance improvement] single api call for storage backend - get media (leverage bubble filter)

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Scott Yan commented:

Ethan WuSherry ChungKenny Hung ( cc Tammy Yang )

the dashboard created only can show 200 asset , Is this expected ?

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Ethan Wu commented:

Scott Yan we haven't implemented pagination yet. so for accounts that have more than 200 assets it will only show 200 assets.

this needs be fixed. maybe in a future release?

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Scott Yan commented:

Sherry ChungKenny Hung qa check it .

use scott@numbers account , i upload by dashboard & turnoff Claim Copyright , it can show in the creator .

but it only can show 200 asset , i think it's need be fix

Copy link
Author

sync-by-unito bot commented Nov 27, 2023

➤ Sherry Chung commented:

Scott Yan OK. Please open task and put in next sprint first

Copy link
Author

sync-by-unito bot commented Nov 28, 2023

➤ Kenny Hung commented:

This issue is here.

[Issue] Manage tab just could load within 200 asset ( https://app.asana.com/0/1201016280880505/1204832352585234/f )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants