Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] sometimes order detail page can’t display normally #2960

Closed
sync-by-unito bot opened this issue Aug 1, 2023 · 2 comments
Closed

[issue] sometimes order detail page can’t display normally #2960

sync-by-unito bot opened this issue Aug 1, 2023 · 2 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 1, 2023

User story

As a user, I want the order detail view to be consistently displayed and provide accurate information every time I access it.

Reproduce step

  1. Press activity
  2. Press order
  3. press one of orders, will enter the order detail page
  4. repeat Bump @types/node from 12.12.50 to 14.0.23 #3 10 times
  5. about 3 times will display this issue.
  6. the result url doesn’t query nid value, just “https://nftsearch.site/asset-profile?nid=”
  7. can’t display image
  8. receiver doesn’t display

IMG_7EE29E5EAD5F-1.jpeg

Expectation

Order detail should display normally every time. (At least QA test 20 times, it shouldn't happen display issue 1 time.)

IMG_11A8400AD19E-1.jpeg

Additional information:

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 7, 2023

➤ Sam commented:

Ethan Wu, just extra information.

From capture cam

  1. I call List all network app orders ( https:// https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/store_network-app-orders_list ) to get user's orders.
  2. Send order_id & asset_id to bubble page

In step 1 I fetch order and try to get related asset id either from order.action_args.nid or order.action_args.cid however some orders might not have action_args at all for example orders like:

  • Creator Gallery
  • One-NUM-price"
  • CustodialWalletWithdraw

does not provide action_args

Therefore we need to clarify with QA what to do in that case?

For example

  • from ionic side we can prevent opening order details page for orders that does not have related asset nid/cid.
  • or from bubble iframe side we can conditionally hide Asset Nid field and Asset thumbnail

@sync-by-unito sync-by-unito bot closed this as completed Aug 17, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 17, 2023

➤ Ethan Wu commented:

SamKenny Hung fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant