Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] Order detail page issues #2957

Closed
sync-by-unito bot opened this issue Aug 1, 2023 · 23 comments
Closed

[issue] Order detail page issues #2957

sync-by-unito bot opened this issue Aug 1, 2023 · 23 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 1, 2023

User story

Reproduce step

  1. Press activity
  2. Press order
  3. press one of orders, will enter the order detail page

issue summary:

  1. Result url: for Mint AVAX NFT, Polygon, ETH, ISCN… it shouldn’t link to asset profile, it should display like the same before.
  2. For example: Mint AVAX should use https://nftrade.com/assets/avalanche/0xb7ccc262d322d1dc1c64cbb56a6827589b4bc874/323 instead of asset profile
  3. Total price should rename Total payment
  4. Copy icon can’t work

IMG_50AB743DCA65-1.jpeg

Expectation

  1. Result url: for Mint AVAX NFT, Polygon, ETH, ISCN… it shouldn’t link to asset profile, it should display like the same before.
  2. For example: Mint AVAX should use https://nftrade.com/assets/avalanche/0xb7ccc262d322d1dc1c64cbb56a6827589b4bc874/323 instead of asset profile
  3. Total price should rename Total payment
  4. Copy icon can’t work

Additional information:

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 7, 2023

➤ Sam commented:

Kenny Hung,

Regarding 3. Copy icon can’t work.

It can be fixed from ionic side and I fixed it. I will include fix for 3. Copy icon can’t work to v230808-capture-app-ionic-launch ( https://app.asana.com/0/0/1205132295508392 )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 9, 2023

➤ Kenny Hung commented:

#3 fixed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 14, 2023

➤ Ethan Wu commented:

Kenny Hung can you provide me some accounts that cover the above test cases.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 14, 2023

➤ Kenny Hung commented:

Ethan Wu

DM'ed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 15, 2023

➤ Ethan Wu commented:

Kenny Hung can you tell me what is the expected result for result url for each of the network actions?

@sync-by-unito sync-by-unito bot closed this as completed Aug 17, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 17, 2023

➤ Ethan Wu commented:

results url screenshots.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 22, 2023

➤ Kenny Hung commented:

Ethan Wu I found some issues.

  1. Total Payment should have four decimal places.
  2. gift, register commit doesn’t have result url
    1. It should link to asset profile.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 22, 2023

➤ Ethan Wu commented:

Kenny Hung what is register commit?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 22, 2023

➤ Ethan Wu commented:

Sam where does iframe pull the orders?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 22, 2023

➤ Ethan Wu commented:

Kenny Hung does this order show up in iframe?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 22, 2023

➤ Ethan Wu commented:

Kenny Hung I have fixed:

  • 4 decimal place Total Payment
  • Gift Capture shows result url as asset profile link

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 22, 2023

➤ Sam commented:

Ethan Wu, right now I away from keyboard. Will answer later with more precision.

It uses API call. You should be able to see which api call its calling by looking at page load events. Once I will be on computer I can share more details.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

SamKenny Hung nvm i figured it out.

kenny its fixed now.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Sam commented:

Ethan Wu, I was recording the video but anyways I will put here.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Sam thanks!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

Ethan Wu

I compare the live version with qa branch, I found the "receiver" is different on "gift" order. The live is right.

BTW, just curious, I found the status is something different than live. In live version, it shows "success", qa branch it shows "complete". (The status part is okay, just want to know why.)

image.png

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Kenny Hung can you provide me the asset id and order id

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

order id: 8c50a273-a65e-492a-a491-84cb57c4b083

asset nid: bafybeibfatqlistf5vehtreadofwi47slximyiyzmq2pmrvhyajnkjyrje

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Kenny Hung the reason is the following

the storage backend api order details only shows the status for payment. it doesn't show the status of the actual network action. the status of the network action is handled by the network action bubble db.

so the challenge is the storage backend api only provides certain information (payment, receiver, order_id, payment status) but it doesn't show any information about result_url or network action status.

so we need to pull from two areas to populate the information.

in the case of Commit, this is not a network action so the only status we can pull is from storage backend.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Ethan Wu commented:

Kenny Hung fixed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 23, 2023

➤ Kenny Hung commented:

QA pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant