Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] The sort of asset which uploads from dashboard is wrong, display on the bottom instead of the top. #2791

Closed
sync-by-unito bot opened this issue May 12, 2023 · 32 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 12, 2023

User story

As a creator, I want my assets that I have uploaded from the dashboard to show up on the "mycapture" tab of the Capture app, so that I can easily access and view them on my mobile device.

Reproduce step

  1. Login dashboard with the account which has more assets
  2. Upload an image
  3. Progress finished & updated on capture app, that asset doesn't show on the "mycapture tab" of the capture app.

Expectation

for the issue that dashboard uploads cannot be shown, it should be dashboard to fix in integrity proof and use 13 digits. Once it is fixed, the issue can be fixed.

The asset uploaded from dashboard should also show on the top of "mycapture tab" on the capture app.

Additional information:

New account doesn't have this issue

Only happened on the account which has more assets (Approximately 500+ assets)

Test account: [email protected]

Doesn't show on the capture app asset nid: bafybeibzaxkepz6fkuojgfsov4uutok7itt3a3zanz5htbxm2ynm3rrqwq

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Kenny Hung commented:

QA suggest it should arrange into 0605 sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 4, 2023

➤ Tammy Yang commented:

Kenny Hung does this still exist? Because it may be a critical issue.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 12, 2023

➤ Sam commented:

Kenny Hung, I couldn't reproduce.

I did the following

  1. Go to https://dashboard.captureapp.xyz/main?tab=createnft ( https://dashboard.captureapp.xyz/main?tab=createnft )
  2. Upload a photo
  3. Download capture app 0.79.0 (iOS) AppStore
  4. Login to capture app
  5. I can see capture uploaded from dashboard

Screenshot 2023-06-12 at 3.52.39 PM.png

On capture app 0.79.0 I can see same asset uploaded from dashobard

IMG_4720.PNG

This is asset NID bafybeifeldewnj52nohroirpkeuapcgvp6nu5bdsezc7jrlq4jdmwloosi

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 12, 2023

➤ Kenny Hung commented:

Sam The root cause QA doesn't confirm yet, but I use "[email protected]" could reproduce this issue. You could refer additional information.

I could DM this test account password.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 12, 2023

➤ Sam commented:

Kenny Hung, I logged in "[email protected] ( mailto:[email protected] )" and find 3 assets that can not be shown in capture app.

I will look further and see what is the root cause tomorrow.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Sam commented:

Kenny Hung

There are 2 things to fix (added as subtasks for this task):

  1. [Issue] Ensure consistency between capture signatures Uploaded from Capture Dashboard and Capture App ( https://app.asana.com/0/0/1204813450236924 )
  2. [issue] Ensure consistency between capture timestamps Uploaded from Capture Dashboard and Capture App ( https://app.asana.com/0/0/1204813450236925 )

Just in case I attached 2 captures for comparison

  • 1 uploaded from capture app
  • 1 uploaded from dashboard

Here is the claap explaining root cause in more details:

https://app.claap.io/numbers-protocol/root-cause-issue-capture-app-doesn-t-show-the-asset-which-uploads-from-dashboard-c-O35CsUM4Uy-5dGkhSMCEmft ( https://app.claap.io/numbers-protocol/root-cause-issue-capture-app-doesn-t-show-the-asset-which-uploads-from-dashboard-c-O35CsUM4Uy-5dGkhSMCEmft )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Kenny Hung commented:

Sam (cc Tammy YangScott YanEthan Wu) Thanks for your clarify!

Just confirm for [email protected] ( mailto:[email protected] ), the asset from dashboard is existed on capture app mycapture just displays on the most bottom, right?

Tammy Yang for signature & timestamp needs your help to confirm the spec of them.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Olga commented:

Sam Sure. Our backend can execute a script to correct the timestamp and signature for assets whose signature starts with the string '{"provider":"CaptureDashboardSignatureProvider"'.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Tammy Yang commented:

Kenny HungSam this should be a Capture dashboard issue. Please ask Ethan Wu to fix. The signature and timestamp format should be unified. Since Capture App is the earlier product, it should be the dashboard to fit the spec used by Capture dashboard.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Tammy Yang commented:

Bofu Chen check the claap or the screenshot. This is related to the data and signature spec so I think you should know.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Bofu Chen commented:

Tammy Yang These are technical debts in Capture App. I recommend

  1. Change timestamp from 13-digit to 10-digit in Capture App
  2. Change signature from object to a list of object(s) in Capture Dashboard

The considerations are

  1. Minimum efforts to make Capture Dashboard to be compatible with Capture App
  2. Will not touch Capture App signature/verification currently
    1. We need a clear plan to update Capture App's signature mechanism to make it compatible with current design.
    2. We will need to update Storage Backend as well.

Let me know what you think.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Sam commented:

Bofu Chen regarding timestamp can we keep 13 digit (as in capture app)? In javascript Date.now() is generating 13 digit timestamp.

According to GPT:

The choice of using either a 10-digit or 13-digit timestamp depends on the requirements of your application. If you need more precise timing, such as for high-frequency events or precise measurements, a 13-digit timestamp with millisecond precision would be more suitable. Otherwise, a 10-digit timestamp may be sufficient.

And it seems like bubble's default timestamp ( https://forum.bubble.io/t/how-to-shorten-the-unix-number/237085/5 ) is 13 digit need to clarify with Ethan Wu.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Sam commented:

Kenny Hung please help to re-arrange this task since it's not relevant to v230613-capture-app-ionic-launch ( https://app.asana.com/0/0/1204495833338689 ) 🙏

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 14, 2023

➤ Kenny Hung commented:

Tammy YangSam (cc Scott YanBofu Chen)

Because this issue needs more discussion on how to figure out the root cause (spec of signature & timestamp). I'll push it to patch sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 18, 2023

➤ Tammy Yang commented:

Kenny Hung here are product decisions for showing the orders of the Captures

  1. For the Explorer page, the order should be the updated_at of the prodct (see redoc ( https://dia-backend.numbersprotocol.io/api/v3/redoc/#operation/store_products_read ))
  2. For Capture Dashboard (pure web based), My Capture page should sort Captures by updated_at of the asset (see redoc ( https://dia-backend.numbersprotocol.io/api/v3/redoc/#operation/assets_read ))
  3. For Capture App, we want to have a bit more updates
  • Change CAPTURED tab to VALIDATED
  • Add an additional tab called DRAFT next to COLLECTED
  • VALIDATED = UPLOADED successfully (follow the order as Bump protractor from 5.4.4 to 7.0.0 #2)
  • DRAFT = CAPTURED but NOT yet uploaded (follow the existing rule in the Capture App)
  • Need the same adjustment for iframe while browsing others' Captures (no DRAFT should be shown, only VALIDATED or COLLECTED)

Let me know if this makes sense.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 19, 2023

➤ Kenny Hung commented:

^^ These parts also involve the backend. (cc OlgaJames ChienScott Yan )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 19, 2023

➤ Olga commented:

Kenny Hung

I believe the current version of the storage backend is sufficient to support #1 and #2. Tammy Yang has provided the necessary fields and API documentation.

Additionally, the new version will correct the format of the timestamp and signature in the API asset response, ✓ Ensure the alignment of timestamp and signature generated from both the Capture App and Capture Dashboard ( https://app.asana.com/0/1201016280880508/1204823732779027/f ).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 19, 2023

➤ Kenny Hung commented:

Olga (cc Sam ) Thanks.

Just confirm about ✓ Ensure the alignment of timestamp and signature generated from both the Capture App and Capture Dashboard ( https://app.asana.com/0/1201016280880508/1204823732779027 )

This task is included both below, right?

  1. [Issue] Ensure consistency between capture signatures Uploaded from Capture Dashboard and Capture App ( https://app.asana.com/0/0/1204813450236924/f )
  2. [issue] Ensure consistency between capture timestamps Uploaded from Capture Dashboard and Capture App ( https://app.asana.com/0/0/1204813450236925/f )

@sync-by-unito sync-by-unito bot changed the title [Issue] Capture app doesn't show the asset which uploads from dashboard [Issue] The sort of the asset which uploads from dashboard is wrong Jun 19, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 19, 2023

➤ Olga commented:

Not really. The task only updates the output response in the storage backend, while #1 and #2 update the input to the storage backend. It's also important to ensure input consistency between the Capture Dashboard and Capture App.

@sync-by-unito sync-by-unito bot changed the title [Issue] The sort of the asset which uploads from dashboard is wrong [Issue] The sort of asset which uploads from dashboard is wrong, display on the bottom instead of the top. Jun 19, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 19, 2023

➤ Kenny Hung commented:

Updated the title of this task & split tasks from Tammy's comment. ( https://app.asana.com/0/0/1204559093594742/1204849172244006/f )

  1. [FR] Add new tab "DRAFT" on mycapture tab ( https://app.asana.com/0/0/1204853349516576/f )
  2. Change CAPTURED tab to VALIDATED ( https://app.asana.com/0/0/1204853349516581/f )
  3. Change CAPTURES tab to VALIDATED on iframe creator page ( https://app.asana.com/0/0/1204853349516586/f )
  4. For the Explorer page, the order should be the updated_at of the product ( https://app.asana.com/0/0/1204853349516591/f )
  5. For Capture Dashboard (pure web based), My Capture page should sort Captures by updated_at of the asset ( https://app.asana.com/0/0/1204853349516596/f )

Suggest arranging them into next sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Sam commented:

Kenny Hung, what QA expects from this task?

You split this task to 5 tasks Comment by @kenny Hung on [Issue] The sort of asset which uploads from dashboard is wrong, display on the bottom instead of the top. ( https://app.asana.com/0/0/1204559093594742/1204853351495030/f )

Which one should be covered in this taks?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Kenny Hung commented:

Sam (cc Tammy Yang)

For your question, I update the expectation of this task.

  1. The asset uploaded from dashboard should also show on the top of "mycapture tab" on the capture app.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Tammy Yang commented:

Kenny Hung to clarify, we don't want big change in the Capture system.

Therefore, it should be iframe to change the proof so that it is consistent with Capture App. I have confirmed this with Bofu Chen , although UNIX timestamp is recommended, application can still keep the flexibility to use different timestamp ONLY in the integrity proof.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Tammy Yang commented:

To summarize what needs to be done by Capture App in every task listed in Comment by @kenny Hung on [Issue] The sort of asset which uploads from dashboard is wrong, display on the bottom instead of the top. ( https://app.asana.com/0/1204559093594742/1204559093594742/1204853351495030 )

  1. Add a new tab for photos that not yet completed the uploading (I.e. distinguish them from the current Capture tab)

  2. Change the tab name

  3. This is an iframe task nothing needs to be done in App side

  4. Same, this is an iframe task

  5. Same, nothing needs to be done in the App side, this is a dashboard issue

To summarize, for the issue that dashboard uploads cannot be shown, it should be dashboard to fix in integrity proof and use 13 digits. Once it is fixed, the issue can be fixed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Tammy Yang commented:

This is very important but a bit complicated, please make sure we all 100% sure what to do. Otherwise, it can cause significant chaos.

Regarding the timestamp system, here is the summary:

  • Backend - UNIX (10 digits)

=> Regustration time - UNIX (10 digits) since this is generated by backend

  • Integrity proof - Javascript (13 digits) => App and Dashboard should align

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Sam commented:

Tammy Yang Thank you for clarification Comment by @tammy Yang on [Issue] The sort of asset which uploads from dashboard is wrong, display on the bottom instead of the top. ( https://app.asana.com/0/0/1204559093594742/1204086179720464/f )

Kenny Hung, so if task 1. and 2. are capture app related then for PATCH sprint can we do this?

v230627-capture-app-ionic

next sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Kenny Hung commented:

Tammy YangEthan Wu (cc SamScott Yan)

Thanks for the clarification, I'll re-arrange this task & this task should be related dashboard.

Sam For task arrangement

I suggest Change CAPTURED tab to VALIDATED ( https://app.asana.com/0/1201016280880500/1204853349516581/f ) & [FR] Add new tab "DRAFT" on mycapture tab ( https://app.asana.com/0/1201016280880500/1204853349516576/f ) arranging into 1 sprint because the UI/UX should be

  1. Register incomplete asset: shown on DRAFT
  2. Register completely asset: shown on VALIDATED

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Sam commented:

Kenny Hung, sure, if we want

to one sprint then I would recommend to add it next sprint after 23.06.19 PATCH sprint.

How do you think? 🤔

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Kenny Hung commented:

Sam (cc Tammy Yang)

Yes, I've pushed v230627 to v230711-capture-app-ionic (postpone from 0627) ( https://app.asana.com/0/0/1204833080003292 ).

If I arrange both of them into v230711 release, is it okay?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 30, 2023

➤ Kenny Hung commented:

Sam

As I checked, this task is fixed by ✓ Ensure the alignment of timestamp and signature generated from both the Capture App and Capture Dashboard ( https://app.asana.com/0/1201016280880508/1204823732779027/f ), does there any other things need to do?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 5, 2023

➤ Ethan Wu commented:

Sam do we need to do anything with this one?

according to Kenny Hung previous comments it seems like this one is ok?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 5, 2023

➤ Sam commented:

Ethan Wu, from dashboard side nothing is needed now. Since backend fix timestamp conversion.

@sync-by-unito sync-by-unito bot closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants