Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v230420-capture-app-iframe #2699

Closed
sync-by-unito bot opened this issue Apr 3, 2023 · 15 comments
Closed

v230420-capture-app-iframe #2699

sync-by-unito bot opened this issue Apr 3, 2023 · 15 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 3, 2023

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

  • A. Full test + backward compatibility
  • B. Full test, no backward compatibility
  • C. Feature test
  • D. Issue fix retest
  • E. Growth

┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title v230418-capture-app-iframe v230420-capture-app-iframe Apr 9, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 21, 2023

➤ Kenny Hung commented:

Ethan Wu I found these items seems not display on qa branch

  1. ✓ [FR] Asset page "more data" can display "device information" ( https://app.asana.com/0/1201016280880500/1203407936005409/f )
  2. ✓ [FR] "COLLECTED" of profile tab could display owner & creator ( https://app.asana.com/0/1201016280880500/1203163306967246/f )
  3. [Issue] Only android - "Copy url" can't work ( https://app.asana.com/0/1201016280880500/1203991109811291/f ) It still can't work.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 21, 2023

➤ Ethan Wu commented:

Kenny Hung I wrote on the release note that these features are in v230420-ethan branch bc qa-release and pending-deploy all have not been reviewed and deployed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 21, 2023

➤ Ethan Wu commented:

To test you need to do it in browser or wait for qa-release branch to be available

@sync-by-unito sync-by-unito bot closed this as completed Apr 27, 2023
@sync-by-unito sync-by-unito bot reopened this May 8, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 8, 2023

➤ Ethan Wu commented:

Kenny Hung FYI this one is re-opened due to not being merged into main branch and the branch was deleted.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 8, 2023

➤ Ethan Wu commented:

Kenny Hung i will have these features re-implemented by thursday.

@sync-by-unito sync-by-unito bot closed this as completed May 10, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 11, 2023

➤ Kenny Hung commented:

Ethan Wu (cc Scott Yan)

iframe-v230420(include v230328+v230425), issue summary, please help to fix them.

  1. For ✓ [issue] User should not see the loading gif underneath, no matter the image size ( https://app.asana.com/0/1201016280880500/1203441427861854/f )
    1. User still see the loading GIF after the image if the image is relatively long and narrow.

  2. NFT field will show repeatedly

  3. Creator page also have badge issue

  4. Some prod seems have some display issue on mycapture tab (when user is in mycapture tab & browse other user’s creator’s page.) Reproduce steps
    1. enter asset detail page on mycapture tab
    2. press username / profile image enter to creator page
    3. press followed by …, will enter to another user’s creator page
    4. enter to any prod will show this issue

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 11, 2023

➤ Ethan Wu commented:

  1. fixed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 11, 2023

➤ Ethan Wu commented:

  1. fixed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 11, 2023

➤ Ethan Wu commented:

  1. i am unable to reproduce the issue that you. screen recording. I am testing this on browser.

the environment is the same as what you see from my captures bc you don't see the top tool bar.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Kenny Hung commented:

Ethan Wu About #4, I record a video for you, maybe you need to use real device could reproduce it.

test apk: https://drive.google.com/file/d/1wuMC7k_GZ-p2YxNdtWP62lSTQqvJ3T94/view?usp=share_link ( https://drive.google.com/file/d/1wuMC7k_GZ-p2YxNdtWP62lSTQqvJ3T94/view?usp=share_link )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Ethan Wu commented:

Kenny Hung my question now is was it ok before?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Kenny Hung commented:

Tammy Yang (cc Ethan WuScott Yan)

For prod display issue when user enter from mycapture ,needs your confirmation. I draw a flow for this.

https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764554194458517&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764554194458517&cot=14 )

Ps. current main branch(version-test) is used solution 1.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Tammy Yang commented:

Kenny Hung can you use Claap next time? So that I can click the link and open instead of downloading it

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Kenny Hung commented:

Tammy Yang okay.

Tammy YangEthan Wu (cc Scott Yan)

huddle summary for prod display issue when user enter from mycapture

  1. We decide rollback for prod show issue workaround because this issue isn’t urgent.
  2. Will open a card for that & future sprint to figure out.
  3. In browser that page doesn’t happen issue, but when on capture app, it will happen. We need to find the root cause in the future sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 12, 2023

➤ Kenny Hung commented:

Ethan WuTammy Yang (cc Scott YanSam)

iframe-v230420 qa conditional pass, test note as below.

  1. User still see the loading GIF after the image if the image is relatively long and narrow. -> Conditional pass, Currently, only a very small number of assets experience this issue.

[issue] Prod display issue when user enter from mycapture ( https://app.asana.com/0/1201083422707776/1204588001755687/f ) -> conditional pass, will find the root cause & figure out in the future sprint.

[FR] Asset detail page should support display AI commit field ( https://app.asana.com/0/1201083422707776/1204588004790144/f ) -> when implement this release we haven’t decided to add it in the asset page. Could add it in the future sprint.

  1. [Issue] Mint & share can't updated the caption if the caption is existed ( https://app.asana.com/0/1201016280880500/1204492663049004/f ) -> it’s about network action, happened on live version as well

[FR] iframe should support svg file thumbnail display ( https://app.asana.com/0/1201083422707776/1204588991761599/f ) -> Because dashboard support upload svg file, we may consider add this part in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants