Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] Feature Creator items display the same preview img #1973

Closed
sync-by-unito bot opened this issue Aug 26, 2022 · 22 comments
Closed

[issue] Feature Creator items display the same preview img #1973

sync-by-unito bot opened this issue Aug 26, 2022 · 22 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 26, 2022

User story
As a Capture App user, I want Feature Creator items could display the real preview image so that I I can discover more featured creator easily.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title Feature Creator items display the same preview img [issue]Feature Creator items display the same preview img Aug 26, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 26, 2022

➤ Ethan Wu commented:

I preset this on purpose. Need to discuss where featured creator image will be stored

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 28, 2022

➤ Tammy Yang commented:

This needs to be fixed before it is pushed to store review

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 6, 2022

➤ Tammy Yang commented:

Ethan Wu please get the right photos to be displayed from Natalie Wang and Sofia Yan

@sync-by-unito sync-by-unito bot changed the title [issue]Feature Creator items display the same preview img [issue] Feature Creator items display the same preview img Sep 6, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Natalie Wang commented:

Ethan Wu
Featured photographers will need to upload minimum 4 photos and shoot minimum 4 photos with Capture app.
Photos you need are their photos or their profile image?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Ethan Wu commented:

Natalie Wang Featured Photographer is a section that appears at the top of the Capture App explorer tab.

The appearance is a rectangular card with their profile pic and username. the card itself is also a photo as well. What I need is image from the creator to personalize their card.

If you look at the example, the photographers need to provide the "mountain" image

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Natalie Wang commented:

Ethan Wu to summarize what we huddle earlier :

  • The feature section would require the photographer's account, profile image, banner image.
  • Banner image will be updated through you at backend. Please share the dimension or size required, I'll ask them to provide one fits on it.
  • I'll work with QA on getting their accounts registered.
  • Following the previous point, before new capture app is released. Can we manually set up accounts for photographers? If this is doable, I'll collect info and work with QA on this. Kenny Hung
  • According to the current interface, have at least 4 blocks would look better. ( it also means that we will have 4 photographer's accounts/photos visible in the app when it is pushed live )
  • Following the previous point, if we want to reveal each photographer per week, shall we use some current Capture users's accounts at featured section first? And update them weekly. If this is doable. ( Tammy YangSofia Yan )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Sofia Yan commented:

Natalie Wang
#3&4 a little confuse here, as I know the new Capture app will have much more features but it won’t cut any features we have now, and I think feature photographers in the first few week can definitely use the current app to generate Capture, otherwise it can not be push out on time.

#5&6 Ethan Wu can we have the rest photographers that on hold with blur image or a lock image? To make some it specific for the 12 weeks features?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Natalie Wang commented:

Sofia Yan a bit back earlier Tammy mentioned it's better to let photographers experience the new Capture directly.
If this is not an issue, I can have them register account from the current app.
But will still collect banner image and let Ethan upload from backend, as it is not a current function.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Sofia Yan commented:

Natalie Wang
#3&4 a little confuse here, as I know the new Capture app will have much more features but it won’t cut any features we have now, and I think featured photographers in the first few weeks can definitely use the current app to generate Capture, otherwise I think it can not be push out on time if the new Capture App release on Sep 20, since they still need to take time to take some nice Captures to minted as NFT

#5&6 Ethan Wu can we have the rest photographers that on hold with blur image or a lock image? To make some it specific for the 12 weeks features?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2022

➤ Sofia Yan commented:

These are two things, I didn’t comment on #1&2.

I think for week 1-3’s photographers, it’s not practical to let them take the Capture they want to sell as product in a rush time (well if they’re ok with that). new capture release will be around Sep 20, and must leave some buffer, I think at least for the first featured photographers we need to give her more time to use Capture to take capture.

And register account is just like the way you register your Capture account, if we don’t want the photographers to see the new UI, you just need ask their email and authorization to set an account with an easy pw and when the new app launched, pass the pw to them(they can change the pw by theirselves), don’t even need qa’s help on it

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2022

➤ Natalie Wang commented:

For the account register, I definitely could do, don't meant to use QA resource. It will mostly be just for the first 1-4 photographers. After the app launch, will have them register directly on app.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2022

➤ Natalie Wang commented:

hi all, to ensure the workflow next , I open this task to align everyone.
Setup workflow for featured block on Capture app ( https://app.asana.com/0/1202734240945449/1202937773378844/f )
I propose the workflow and QA review item on this task. Please take a min to check and let me know if it works. Thank you!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2022

➤ Kenny Hung commented:

Ethan Wu (cc Scott YanNatalie Wang)
Could you provide the best size of feature creator banner? Let the banner could display perfect and won't squeeze. Thanks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Ethan Wu commented:

width: 171 px; height: 211 px

settings:
center image
make image as wide as parent element
crop the image to fit the element size

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Tammy Yang commented:

Kenny HungScott Yan please make sure QA can complete this by your own. Ethan Wu should provide you the tools/APIs

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Scott Yan commented:

Tammy Yang yes , qa had created a tool task to ethan like this Upload Feature creator banner tool ( https://app.asana.com/0/1202797132313862/1202943676679983/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Ethan Wu commented:

created backend api workflow in qa-release branch of capture-iframe

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Ethan Wu commented:

need api key. after getting api key i can provide curl commands

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Ethan Wu commented:

endpt:

Add Featured Creator
POST https://captureappiframe.numbersprotocol.io/version-qa-release/api/1.1/wf/create_featured_creator ( https://captureappiframe.numbersprotocol.io/version-qa-release/api/1.1/wf/create_featured_creator )

Header:
Authorization: Bearer

Parameters:
username (text)
address (text)
background_image (image) => needs to file_url

Delete:
POST https://captureappiframe.numbersprotocol.io/version-qa-release/api/1.1/wf/delete_featured_creator ( https://captureappiframe.numbersprotocol.io/version-qa-release/api/1.1/wf/delete_featured_creator )

Header:
Authorization: Bearer

Parameters:
address (text)

edit creator
POST https://captureappiframe.numbersprotocol.io/version-qa-release/api/1.1/wf/edit_featured_creator ( https://captureappiframe.numbersprotocol.io/version-qa-release/api/1.1/wf/edit_featured_creator )

Header:
Authorization: Bearer

Parameters:
username (text) => optional
address (text)
background_image (image) => needs to file_url => optional

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Kenny Hung commented:

Ethan Wu (cc Scott Yan)Need the Bearer token, thanks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Tammy Yang commented:

DM'ed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 20, 2022

➤ Ethan Wu commented:

✓ Upload Feature creator banner tool ( https://app.asana.com/0/1202797132313862/1202943676679983/f ) is done and qa is testing. code review in progress

also changes were made last sprint to account for different background image.

@sync-by-unito sync-by-unito bot closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants