-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-App referral program #1536
Comments
➤ Tammy Yang commented: Please ignore the daily tasks part for this sprint |
➤ Sam commented: Tammy Yang where I can get the design file for invitation page? Was that implemented? We discussed details in last sprint planning but I forgot 🤦♂️ the detail. Would be nice to have short description of what is expected from me to be done😅🙏 |
➤ Tammy Yang commented: DaYuan please provide |
➤ DaYuan commented: Sam you can look here https://www.figma.com/file/cUxfOnPrQI5khYjZeBUwaA/?node-id=2650%3A29019 ( https://www.figma.com/file/cUxfOnPrQI5khYjZeBUwaA/?node-id=2650%3A29019 ) |
➤ James Chien commented: Sam The current user's referral code can be retrieved by this API call, the referral_code field in response When registration using Sign Up API (https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create )), add a request body field referral_code if user enters the referral_code (do not add this field if user did not enter referral_code, because if the field is present inputting invalid referral code will return 400 error) Let me know if there's anything else you need or if there's anything unclear |
➤ Sam commented: James Chien 1st case: When user enter referral code from sign up page I will use this API endpoint (https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create )) 2nd case: When user enter referral code from invitation page. Which API endpoint I should use? |
➤ James Chien commented: Sam I did not aware of the invitation page feature before. I'll need to add an API for entering the invitation code after confirming some details. |
➤ Sam commented: James Chien what if user enters referral code that can pass form validation but does not exist in the backend? |
➤ James Chien commented: Sam When submitting the form (sending the request) you'll get a 400 error from backend and the response will have an |
➤ James Chien commented: And just use the error toast to let user know that the referral code is invalid |
➤ Sam commented: Sofia Yan I used google translate and not sure if these are correct Referral Code (Optional) = 推薦代碼(可選) |
➤ Sam commented: James Chien here is the pull request Feature in app referral program ( #1594 ) |
➤ Sam commented: Tammy Yang for now I put simple text for share button. Let me know if text should be changed |
➤ Sam commented: Tammy Yang can I remove this fb, line, email icons? There is no ready plugin that allows share in fb directly or something. It can be implemented by creating another plugin or adding another plugin to support share view fb, line or email might take more time. Currently when user clicks share button it shows native UI that can share in any apps that users installed in their app. Like in FullSizeRender.MOV demo video |
➤ Tammy Yang commented: Yes, please |
➤ Tammy Yang commented: Also, I think the color of the button is not consistent with other buttons in the App. Please feel free to change it. |
➤ Tammy Yang commented: Sam since this has conditionally passef QA, I think you can complete it. |
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang
The text was updated successfully, but these errors were encountered: