Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inserting comments using IRBuilder #962

Closed
apmasell opened this issue Jun 16, 2023 · 1 comment · Fixed by #963
Closed

Allow inserting comments using IRBuilder #962

apmasell opened this issue Jun 16, 2023 · 1 comment · Fixed by #963
Labels
feature_request Feature Request
Milestone

Comments

@apmasell
Copy link
Contributor

I'm proposing adding a comment pseudo-instruction to IRBuilder that inserts comments into the generated IR. I most use cases, the IR is immediately parsed by LLVM and the comments will be lost, but this could be useful for debugging and generating tutorial information.

@apmasell apmasell added the feature_request Feature Request label Jun 16, 2023
@sklam
Copy link
Member

sklam commented Jun 16, 2023

I think this is a good idea; esp for embedding debug information that LLVM shouldn't care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants