You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PipelineRollout controller and the ISBServiceRollout Controller are performing a Watch() on the owned resources: PipelineRollout reconciler watching Pipelines, and ISBServiceRollout reconciler watching ISBServices. Should it be changed to use this handler.EnqueueRequestForOwner() like numaflow does? That seems to make it so that only the Owner (e.g. PipelineRollout) would get Reconcile() called when the underlying Pipeline changes. We must be calling PipelineRolloutController.Reconcile() for every PipelineRollout instance every time any Pipeline at all changes I imagine.
The text was updated successfully, but these errors were encountered:
The PipelineRollout controller and the ISBServiceRollout Controller are performing a Watch() on the owned resources: PipelineRollout reconciler watching Pipelines, and ISBServiceRollout reconciler watching ISBServices. Should it be changed to use this handler.EnqueueRequestForOwner() like numaflow does? That seems to make it so that only the Owner (e.g. PipelineRollout) would get Reconcile() called when the underlying Pipeline changes. We must be calling PipelineRolloutController.Reconcile() for every
PipelineRollout
instance every time any Pipeline at all changes I imagine.The text was updated successfully, but these errors were encountered: