Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict watching of Pipelines and watching of ISBServices to just the Owners #5

Closed
Tracked by #16
juliev0 opened this issue May 28, 2024 · 0 comments · Fixed by #60
Closed
Tracked by #16

Restrict watching of Pipelines and watching of ISBServices to just the Owners #5

juliev0 opened this issue May 28, 2024 · 0 comments · Fixed by #60
Assignees

Comments

@juliev0
Copy link
Collaborator

juliev0 commented May 28, 2024

The PipelineRollout controller and the ISBServiceRollout Controller are performing a Watch() on the owned resources: PipelineRollout reconciler watching Pipelines, and ISBServiceRollout reconciler watching ISBServices. Should it be changed to use this handler.EnqueueRequestForOwner() like numaflow does? That seems to make it so that only the Owner (e.g. PipelineRollout) would get Reconcile() called when the underlying Pipeline changes. We must be calling PipelineRolloutController.Reconcile() for every PipelineRollout instance every time any Pipeline at all changes I imagine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants