Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only enable console_error_panic_hook in tests #16

Closed
fjarri opened this issue Nov 29, 2020 · 1 comment · Fixed by #51
Closed

Only enable console_error_panic_hook in tests #16

fjarri opened this issue Nov 29, 2020 · 1 comment · Fixed by #51
Labels
tests Test suite WASM Related to WASM bindings

Comments

@fjarri
Copy link
Contributor

fjarri commented Nov 29, 2020

console_error_panic_hook library is very useful for testing in WASM bindings, but should the release version of the library have it? It increases the WASM size noticeably.

Also figure out where it is better to initialize it. Currently console_error_panic_hook::set_once() is called from SecretKey::random() which may not be used at all in some scenarios.
@fjarri fjarri added tests Test suite WASM Related to WASM bindings labels Nov 29, 2020
@fjarri
Copy link
Contributor Author

fjarri commented Apr 23, 2021 •
edited
Loading

May not need at all if all the errors are properly propagated (see #14)

@fjarri fjarri mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Test suite WASM Related to WASM bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trait implementations and error handling fjarri/rust-umbral
1 participant
@fjarri