Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using BLAKE2b from hashlib? #155

Open
cygnusv opened this issue May 28, 2018 · 2 comments
Open

Using BLAKE2b from hashlib? #155

cygnusv opened this issue May 28, 2018 · 2 comments

Comments

@cygnusv
Copy link
Member

cygnusv commented May 28, 2018

Cryptography.io's implementation of BLAKE2b doesn't offer any of the additional inputs supported by it (e.g., key, salt, personalization, etc.). This is due to OpenSSL implementation, which apparently won't ship it until version 1.2. However, Python's hashlib provides all that.

Several questions arise: should we move to hashlib? how hard do we want these features? what potential problems may arise in this case?

@michwill
Copy link

I do like hashlib, but I am not sure we desperately need all those additional features.
The problem is, of course, compatibility with some languages where implementations with those additional features aren't readily available.

@tuxxy
Copy link
Contributor

tuxxy commented May 28, 2018

I also agree with @michwill. I can see why we need the additional inputs for domain separation and I would like to use them. A concern I share is implementation in other languages. I haven't done the research yet to see the availability of said inputs, I don't think it will be difficult to find compatible libraries. I believe Blake2b to be in the stdlib of Go, for example and should probably offer these additional inputs.

For the time being, 👍 to using hashlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants