You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what you would like to achieve
The tests should validate that an ignored (per the config) prefix is not having messages generated about it and thus is actually being ignored, rather than alerted upon.
Describe why the current solution (if any) is not satisfactory
Currently there are a number of tests that assert expected messages are generated from the relevant monitors.
It is possible to have additional tests, not existing in the expectedData, which are never 'seen' by the current test logic.
Provide an example
On current master (pre #100), add an example update for an ignored prefix to the misconfiguration data in connectorTest.js;
{
id: '2914',
origin: 'asn-monitor',
earliest: 1576436988706,
latest: 1576436988707,
affected: 2914,
message: 'AS2914 is announcing 2.2.2.3/22 but this prefix is not in the configured list of announced prefixes',
data: [
{
extra: {},
matchedRule: [Object],
matchedMessage: [Object],
timestamp: 1576436988706
},
{
extra: {},
matchedRule: [Object],
matchedMessage: [Object],
timestamp: 1576436988707
},
{
extra: {},
matchedRule: [Object],
matchedMessage: [Object],
timestamp: 1576436988707
}
]
}
{
id: '3333',
origin: 'asn-monitor',
earliest: 1576436988707,
latest: 1576436988708,
affected: 3333,
message: 'AS3333 is announcing 2a0e:240::/32 but this prefix is not in the configured list of announced prefixes',
data: [
{
extra: {},
matchedRule: [Object],
matchedMessage: [Object],
timestamp: 1576436988707
},
{
extra: {},
matchedRule: [Object],
matchedMessage: [Object],
timestamp: 1576436988708
}
]
}
And asserts 1 message;
Alerting
✓ asn monitoring reporting (1013ms)
The second (incorrect) message should either be asserted to not exist (explicit ignore check), or the number of messages should match the length of the expected data (implicit, no additional messages check).
The text was updated successfully, but these errors were encountered:
Describe what you would like to achieve
The tests should validate that an ignored (per the config) prefix is not having messages generated about it and thus is actually being ignored, rather than alerted upon.
Related issue: #100
Describe why the current solution (if any) is not satisfactory
Currently there are a number of tests that assert expected messages are generated from the relevant monitors.
It is possible to have additional tests, not existing in the expectedData, which are never 'seen' by the current test logic.
Provide an example
On current master (pre #100), add an example update for an ignored prefix to the
misconfiguration
data in connectorTest.js;The test receives 2 messages (1 incorrect);
And asserts 1 message;
The second (incorrect) message should either be asserted to not exist (explicit ignore check), or the number of messages should match the length of the expected data (implicit, no additional messages check).
The text was updated successfully, but these errors were encountered: