Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

feat: trusted key-value store using sgxfs #61

Merged
merged 29 commits into from
May 20, 2021
Merged

feat: trusted key-value store using sgxfs #61

merged 29 commits into from
May 20, 2021

Conversation

PiDelport
Copy link
Collaborator

(Closes #36)

@PiDelport PiDelport added the feat New feature or request label May 17, 2021
@PiDelport PiDelport added this to the Execution token issuance milestone May 17, 2021
@PiDelport PiDelport self-assigned this May 17, 2021
@PiDelport PiDelport removed this from the Execution token issuance milestone May 17, 2021
@PiDelport PiDelport force-pushed the feat-trusted-kv-store-36 branch 3 times, most recently from 2a1c2db to 6e73119 Compare May 18, 2021 18:19
longtomjr
longtomjr reviewed May 19, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comments so far.

rtc_tenclave/src/kv_store/inspect.rs Show resolved Hide resolved
rtc_tenclave/src/kv_store/inspect.rs Outdated Show resolved Hide resolved
longtomjr
longtomjr reviewed May 19, 2021
View reviewed changes
rtc_tenclave/src/kv_store/mod.rs Outdated Show resolved Hide resolved
rtc_tenclave/src/lib.rs Outdated Show resolved Hide resolved
@PiDelport PiDelport marked this pull request as ready for review May 20, 2021 07:34
@PiDelport
refactor(rtc_tenclave,kv_store): rework FsStore, extract Filer trait
b3eea8e 
This should be a lot simpler to work with.
@PiDelport
style(rtc_tenclave,tests): whitespace inside macro
dc12fe6
@PiDelport
test(rtc_tenclave): pull function out of proptest macro
4d1a8c8 
This lets formatting and analysis work better.
@PiDelport
deps(rtc_tenclave): add tempfile for tests
80a1d5e
@PiDelport
test(rtc_tenclave): simplify using tempfile::TempDir
5f8bbcc
@PiDelport
test(rtc_tenclave,kv_store,std_filer): basic test coverage
674a428
@PiDelport
refactor(rtc_tenclave,kv_store): add Option to Filer.get() result type
6d08635
@PiDelport
feat(rtc_tenclave,kv_store): handle NotFound in Filer
94fb6d3
@PiDelport
check(rtc_tenclave,kv_store): mark functions currently only reference…
35fad2c 
…d in tests
@PiDelport
refactor(rtc_tenclave,kv_store): take save() value by reference
89d8eb2 
This fits better with how the copying store implementations work.
@PiDelport
feat(rtc_tenclave,kv_store): add delete operation
fe14405
This was referenced May 20, 2021
Open
Open
@longtomjr
Copy link
Collaborator

See: #68 and #67
These are not critical, and should not hold up getting this merged, but will be nice to get done after this goes in.

@PiDelport
refactor(rtc_tenclave): drop use of feature(impl_trait_in_bindings)
b772c56 
Leave the signatures in place as comments, for now, as a reading aid.
longtomjr
longtomjr approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good. Thanks!

@PiDelport
Copy link
Collaborator Author

Cool, thanks!

I just fixed some clippy checks and added a round-trip test, which should be minor: I'll go ahead and merge.

@PiDelport PiDelport merged commit 2d9cd1b into main May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@longtomjr longtomjr longtomjr approved these changes

@Nghondzweni Nghondzweni Awaiting requested review from Nghondzweni

Assignees

@PiDelport PiDelport

Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a module for that abstracts state using SgxFile (in tstd) and serde-json
2 participants
@PiDelport @longtomjr