This repository has been archived by the owner on Jun 12, 2022. It is now read-only.
Fallback to an global comment if the file does not exist in the revision #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this issue but have no time to fix it. Thank you for your PR! |
nthienan
reviewed
Oct 5, 2017
| } catch (e: ConduitException) { | ||
| if (e.message.equals("Requested file doesn't exist in this revision.")) { | ||
| val message = "Unmodified file " + filePath + " on line " + i.line() + "\n\n" + ic | ||
| differentialClient.postComment(diff.revisionId, message) |
There was a problem hiding this comment.
should modify postComment() to not attach inline comments in this case
| log.debug("Comment $ic has been published") | ||
| } catch (e: ConduitException) { | ||
| if (e.message.equals("Requested file doesn't exist in this revision.")) { | ||
| val message = "Unmodified file " + filePath + " on line " + i.line() + "\n\n" + ic |
nthienan
approved these changes
Oct 5, 2017
|
Awesome, thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file being reported on does not exist in the revision then a exception is shown in the Jenkins log and a comment is added listing the number of issues. This may be confusing as a comment may be shown that there are more issue than there are comments.
This adds a fallback for the case described to post a global comment with the file name and line number if it's not found in the revision.