From ea912f69d06db7a12a8a202c098c9f2bc9a05150 Mon Sep 17 00:00:00 2001 From: Mohammad Hossein Sekhavat Date: Sat, 20 Jul 2019 08:19:12 +0000 Subject: [PATCH 1/2] Add missing quotations in Dockerfile example Docker build raises error without those quotations. --- docs/Usage/RemoteKernelConnection.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/Usage/RemoteKernelConnection.md b/docs/Usage/RemoteKernelConnection.md index 5f33ef662..5945543f9 100644 --- a/docs/Usage/RemoteKernelConnection.md +++ b/docs/Usage/RemoteKernelConnection.md @@ -151,8 +151,8 @@ RUN chmod +x /tini ENV JUPYTER_TOKEN=my_secret_token # you can also pass this at runtime EXPOSE 8888 -ENTRYPOINT [/tini, --] -CMD [jupyter-notebook, --no-browser, --port=8888] +ENTRYPOINT ["/tini", "--"] +CMD ["jupyter-notebook", "--no-browser", "--port=8888"] RUN pip install markdown # <- installing new package ``` From eb85403e92b61b380640e8ae0b92c21411fc908b Mon Sep 17 00:00:00 2001 From: Mohammad Hossein Sekhavat Date: Sat, 20 Jul 2019 08:25:25 +0000 Subject: [PATCH 2/2] Update RemoteKernelConnection.md --- docs/Usage/RemoteKernelConnection.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/Usage/RemoteKernelConnection.md b/docs/Usage/RemoteKernelConnection.md index 5945543f9..7d09e8762 100644 --- a/docs/Usage/RemoteKernelConnection.md +++ b/docs/Usage/RemoteKernelConnection.md @@ -73,11 +73,11 @@ RUN chmod +x /tini ENV JUPYTER_TOKEN=my_secret_token # you can also pass this at runtime EXPOSE 8888 -ENTRYPOINT [/tini, --] +ENTRYPOINT ["/tini", "--"] # --no-browser & --port aren't strictly necessary. presented here for clarity -CMD [jupyter-notebook, --no-browser, --port=8888] +CMD ["jupyter-notebook", "--no-browser", "--port=8888"] # if running as root, you need to explicitly allow this: -# CMD [jupyter-notebook, --allow-root, --no-browser, --port=8888] +# CMD ["jupyter-notebook", "--allow-root", "--no-browser", "--port=8888"] ``` @@ -90,8 +90,8 @@ version: '2' services: hydro: build: . - entrypoint: [/tini, --] - command: [jupyter-notebook, --allow-root, --no-browser, --port=8888] + entrypoint: ["/tini", "--"] + command: ["jupyter-notebook", "--allow-root", "--no-browser", "--port=8888"] ports: - 8888:8888 environment: