Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculated kernel for multilanguage #1294

Merged
merged 2 commits into from
Apr 14, 2018
Merged

Fix calculated kernel for multilanguage #1294

merged 2 commits into from
Apr 14, 2018

Conversation

BenRussert
Copy link
Member

@BenRussert BenRussert added the bug 🐛 For unexpected issues label Apr 13, 2018
@BenRussert
Use toJS on outputs
c622c01 
- Closes 1293
@BenRussert
Copy link
Member Author

This will fix #1293 as well. Never should have stopped using toJS here, but flow told me to!

lgeiger
lgeiger approved these changes Apr 14, 2018
View reviewed changes
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lgeiger lgeiger merged commit 7c36256 into nteract:master Apr 14, 2018
@lgeiger
Copy link
Member

lgeiger commented Apr 14, 2018

Let's ship a patch release!

@BenRussert BenRussert mentioned this pull request Apr 14, 2018
Closed
@BenRussert BenRussert deleted the fix-mobx-upgrade branch April 14, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
bug 🐛 For unexpected issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hydrogen kernel shuts down after each command (doesn't stay running as idle)
2 participants
@BenRussert @lgeiger