Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reader: not able to stop a reader when no nsqlookupd address set #196

Closed
shuoli84 opened this issue Oct 3, 2017 · 1 comment · May be fixed by #245
Closed

reader: not able to stop a reader when no nsqlookupd address set #196

shuoli84 opened this issue Oct 3, 2017 · 1 comment · May be fixed by #245
Labels

Comments

@shuoli84
Copy link

shuoli84 commented Oct 3, 2017

The reader's close method will call on_connection_closed, and if nsqlookupd address not set, it will try to reconnect to nsqd after 15 seconds, which means the reader can't be closed in this case?

        # in _on_connection_close()

        if not self.lookupd_http_addresses:
            # automatically reconnect to nsqd addresses when not using lookupd
            logger.info('[%s:%s] attempting to reconnect in 15s', conn.id, self.name)
            reconnect_callback = functools.partial(self.connect_to_nsqd,
                                                   host=conn.host, port=conn.port)
            self.io_loop.add_timeout(time.time() + 15, reconnect_callback)
@mreiferson mreiferson added the bug label Nov 11, 2018
@mreiferson mreiferson changed the title Not able to stop a reader when no lookupd address set? reader: not able to stop a reader when no nsqlookupd address set Nov 11, 2018
@mreiferson
Copy link
Member

mreiferson commented Jun 14, 2020

see #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants