Merge pull request #1373 from ploxiln/ci_go117

CI: add go-1.17 to test matrix, remove go-1.13
nsqio · Sep 6, 2021 · 52b9143 · 52b9143
2 parents d21ec48 + dc60cfd
commit 52b9143
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,10 +12,10 @@ jobs:
       fail-fast: false
       matrix:
         imgtag:
-          - "golang:1.13-buster"
           - "golang:1.14-buster"
           - "golang:1.15-buster"
-          - "golang:1.16-buster"
+          - "golang:1.16-bullseye"
+          - "golang:1.17-bullseye"
         goarch:
           - "amd64"
           - "386"
@@ -44,7 +44,7 @@ jobs:
   send-coverage:
     runs-on: ubuntu-20.04
     timeout-minutes: 30
-    container: "golang:1.16-buster"
+    container: "golang:1.16-bullseye"
     env:
       GOPATH: "${{github.workspace}}/go"
       SRCDIR: "go/src/github.com/nsqio/nsq"
@@ -55,7 +55,7 @@ jobs:
           path: ${{env.SRCDIR}}
 
       - name: Install goveralls
-        run: GO111MODULE=off go get github.com/mattn/goveralls
+        run: go install github.com/mattn/goveralls@latest
 
       - name: Send coverage
         env:

diff --git a/apps/nsq_to_file/nsq_to_file.go b/apps/nsq_to_file/nsq_to_file.go
@@ -136,8 +136,8 @@ func main() {
 	cfg.UserAgent = fmt.Sprintf("nsq_to_file/%s go-nsq/%s", version.Binary, nsq.VERSION)
 	cfg.MaxInFlight = opts.MaxInFlight
 
-	hupChan := make(chan os.Signal)
-	termChan := make(chan os.Signal)
+	hupChan := make(chan os.Signal, 1)
+	termChan := make(chan os.Signal, 1)
 	signal.Notify(hupChan, syscall.SIGHUP)
 	signal.Notify(termChan, syscall.SIGINT, syscall.SIGTERM)