Makefile: Fix sync-tree
#941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, `make [sync-tree]` target started to fail on JSON parsing: ``` parse error: Invalid numeric literal at line 7, column 10 ``` This was caused by `syncTree.sh` script requesting source code dir from NeoFS Node repository. For some time now the answer began to come in HTML format instead of JSON, which is why `jq` failed. From now script attaches `Accept: application/json` header to get JSON response from the GitHub. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 26.92% 26.92%
=======================================
Files 87 87
Lines 14129 14129
=======================================
Hits 3804 3804
Misses 9903 9903
Partials 422 422 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
GH has nice RESTful APIs, but they all require access tokens (although maybe GITHUB_TOKEN or whatever it's called can work this way). I'd rather use git submodules here, frankly, but all of these constructions are obviously temporary, so if this fixes the build for now -- let's do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i tried to fix for #940, and saw a request for a fix within #939 late. We can handle this before or just cherry-pick there, up to you @roman-khimov @smallhive
in the future, i'd try to switch to using some stable GitHub API (trees or contents)