-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for aws-chunked #914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
force-pushed
the
913-add-support-for-aws-chunked
branch
from
November 30, 2023 12:00
598dcf0
to
e71b007
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
- Coverage 34.43% 33.78% -0.66%
==========================================
Files 62 64 +2
Lines 10594 10799 +205
==========================================
Hits 3648 3648
- Misses 6540 6745 +205
Partials 406 406 ☔ View full report in Codecov by Sentry. |
smallhive
force-pushed
the
913-add-support-for-aws-chunked
branch
from
November 30, 2023 12:19
e71b007
to
3804b64
Compare
roman-khimov
requested changes
Nov 30, 2023
smallhive
force-pushed
the
913-add-support-for-aws-chunked
branch
from
December 1, 2023 07:07
3804b64
to
9c026cd
Compare
Also added some tests |
smallhive
force-pushed
the
913-add-support-for-aws-chunked
branch
from
December 1, 2023 07:40
9c026cd
to
739978c
Compare
roman-khimov
reviewed
Dec 1, 2023
The implementation is copied from net/http/internal/chunked.go. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
closes #913. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
913-add-support-for-aws-chunked
branch
from
December 1, 2023 10:18
739978c
to
b20cfa7
Compare
roman-khimov
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #913