Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aws-chunked #914

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

smallhive
Copy link
Contributor

Closes #913

@smallhive smallhive force-pushed the 913-add-support-for-aws-chunked branch from 598dcf0 to e71b007 Compare November 30, 2023 12:00
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 206 lines in your changes are missing coverage. Please review.

Comparison is base (a6a9094) 34.43% compared to head (b20cfa7) 33.78%.
Report is 1 commits behind head on master.

Files Patch % Lines
api/auth/signer/v4/chunked_reader.go 0.00% 161 Missing ⚠️
api/auth/signer/v4/chunk_signer.go 0.00% 36 Missing ⚠️
api/auth/center.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   34.43%   33.78%   -0.66%     
==========================================
  Files          62       64       +2     
  Lines       10594    10799     +205     
==========================================
  Hits         3648     3648              
- Misses       6540     6745     +205     
  Partials      406      406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallhive smallhive force-pushed the 913-add-support-for-aws-chunked branch from e71b007 to 3804b64 Compare November 30, 2023 12:19
@smallhive smallhive marked this pull request as ready for review November 30, 2023 12:30
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/stream.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 913-add-support-for-aws-chunked branch from 3804b64 to 9c026cd Compare December 1, 2023 07:07
@smallhive
Copy link
Contributor Author

Also added some tests

api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/stream.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/signer/v4/chunked.go Outdated Show resolved Hide resolved
api/auth/center_test.go Outdated Show resolved Hide resolved
The implementation is copied from net/http/internal/chunked.go.

Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
closes #913.

Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
@roman-khimov roman-khimov merged commit e707b66 into master Dec 1, 2023
14 of 16 checks passed
@roman-khimov roman-khimov deleted the 913-add-support-for-aws-chunked branch December 1, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for aws-chunked
2 participants