Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check x-amz-expires header on maximum border #893

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

smallhive
Copy link
Contributor

Fixing authmate wasn't enough.

Closes #853.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #893 (cee8d84) into master (002c154) will increase coverage by 0.03%.
Report is 7 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   34.43%   34.46%   +0.03%     
==========================================
  Files          62       62              
  Lines       10583    10584       +1     
==========================================
+ Hits         3644     3648       +4     
+ Misses       6532     6530       -2     
+ Partials      407      406       -1     
Files Coverage Δ
api/auth/center.go 15.44% <0.00%> (-0.20%) ⬇️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@smallhive smallhive marked this pull request as ready for review November 3, 2023 04:08
@roman-khimov roman-khimov merged commit a4fdc47 into master Nov 3, 2023
14 of 16 checks passed
@roman-khimov roman-khimov deleted the 853-amz-expires branch November 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Amz-Expires upper limit should be limited to 7 days
2 participants