Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle limits for DeleteObjects requests #844

Closed
evgeniiz321 opened this issue Oct 12, 2023 · 0 comments · Fixed by #849
Closed

Handle limits for DeleteObjects requests #844

evgeniiz321 opened this issue Oct 12, 2023 · 0 comments · Fixed by #849
Assignees
Labels
bug Something isn't working
Milestone

Comments

@evgeniiz321
Copy link

if we try to delete a big number of objects at once (e.g. 1001) - s3 gate hangs and a client receives 'Read timeout on endpoint URL: "https://s3.neofs.devenv:8080/yournamehere-93h9ppiq24ny870o-1?delete' instead of a proper error.

2023-10-12T00:19:25.192Z	error	handler/delete.go:254	couldn't delete objects ...
errors": [{"error": "mark object removal via connection pool: remove object via client: delete object on client: rpc error: code = Canceled desc = context canceled"}, {"error": "failed to get node by path: rpc error: code = Canceled desc = context canceled"}
...
023-10-12T00:19:25.193Z	error	handler/util.go:29	call method	{"status": 500, "request_id": "e665a319-686c-425b-a7ab-bac63c4b23ec", "method": "DeleteMultipleObjects", "bucket": "yournamehere-93h9ppiq24ny870o-1", "object": "", "description": "could not write response", "error": "encode xml response: write tcp 192.168.130.82:8080->192.168.130.1:42882: write: broken pipe"

There should be some limits introduced on the amount of objects that can be deleted in a one request. Test test_multi_object_delete_key_limit assumes the limit is 1000, if bigger - it expects to get the 400 status code.

Full logs from the gate - s3_gate.tar.gz

@evgeniiz321 evgeniiz321 added bug Something isn't working triage labels Oct 12, 2023
@roman-khimov roman-khimov added this to the v0.30.0 milestone Oct 12, 2023
@smallhive smallhive self-assigned this Oct 13, 2023
smallhive added a commit that referenced this issue Oct 13, 2023
Closes #844.

Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive added a commit that referenced this issue Oct 16, 2023
Closes #844.

Signed-off-by: Evgenii Baidakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants