meta: fix upgrade to v3 #3048
Merged
meta: fix upgrade to v3 #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3048 +/- ##
==========================================
+ Coverage 22.41% 22.43% +0.01%
==========================================
Files 791 791
Lines 58405 58381 -24
==========================================
+ Hits 13093 13096 +3
+ Misses 44416 44386 -30
- Partials 896 899 +3 ☔ View full report in Codecov by Sentry. |
|
For now, the only idea of how this could happen is restarting before migration is completed. |
|
But it all happens in a single transaction, either it's in or it's out. |
Fixes
error shard/control.go:17 metabase failure, switching mode {"shard_id": "XxhmeQZZRSQfDGfiCYo9mB", "stage": "init", "mode": "READ_ONLY", "error": "migrating from 2 to 3 version failed, consider database resync: graveyard value with unexpected 72 length"}
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
fix-meta-upgrade
branch
from
da61ece to
d34687c
Compare
roman-khimov
added
bug
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
|
The key is 2addebf, yes. And that was present in the original patch as well. |
There was a problem hiding this comment.
@roman-khimov d34687c worth changelog to me, very admin-friendly change
cthulhu-rider
approved these changes
Dec 12, 2024
I don't think it changes anything for the admin, especially now. This would be a (really minor) issue for us when migration from 3 to 4 is to appear, old structure can handle this too, but it's somewhat less convenient. |
Use complete DB reload to get closer to how node works in real life, it usually opens an existing DB and any open/init code can affect the result. Signed-off-by: Roman Khimov <[email protected]>
It wasn't updated previously leading to attempts to upgrade the DB on every
start. Which then leads to
error shard/control.go:17 metabase failure, switching mode {"shard_id": "XxhmeQZZRSQfDGfiCYo9mB", "stage": "init", "mode": "READ_ONLY", "error": "migrating from 2 to 3 version failed, consider database resync: graveyard value with unexpected 72 length"}
on 0.44.0/0.44.1.
Signed-off-by: Roman Khimov <[email protected]>
Reuse getVersion(). Signed-off-by: Roman Khimov <[email protected]>
Too short and generic name, shadowed already in updateVersion(). Signed-off-by: Roman Khimov <[email protected]>
This code was added in 6f243a2 and it looks like it was mainly to ensure some correct processing of metabases that have no version info stored at all (they could've had some valid data still). Nowadays all correct metabases have version data stored, if it's not there it's either a broken or a new (more likely) DB. Also, doing any things like that in Open() is suspicious, it shouldn't care much about the state, that's what Init() is for. Notice that ErrOutdatedVersion for unknown versions is handled above. Signed-off-by: Roman Khimov <[email protected]>
Each handler works with a particular version, each updates to the next version, chaining them we're getting to the current, that's it. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
fix-meta-upgrade
branch
from
d34687c to
d16d757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.