node: add check for unmarshalling config to validate

[End-rey]

This is a check in case there is a ",remain" tag in the configuration field, and if there is an incorrect data format, then the value of the field was ignored, since then there will be a check to see if this field is correct or not. This makes some errors clearer after unmarshalling.

Closes #3034.

Actually, I don't like this fix. I want the attribute field to be a list.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.62%. Comparing base (7b592bd) to head (ff65a8c).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/neofs-node/config/config.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   22.63%   22.62%   -0.01%     
==========================================
  Files         791      791              
  Lines       58615    58616       +1     
==========================================
- Hits        13265    13264       -1     
- Misses      44452    44454       +2     
  Partials      898      898              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[roman-khimov]

Far from being pretty, but looks like unavoidable at the same time.

Changes to go.mod?

Can we also not throw a panic from SN and fail gracefully?

[roman-khimov]

At the same time, if we're to do #2993, this won't be a problem, right?

[End-rey]

Changes to go.mod?

No, mapstructure is a part of the viper package and it's been in go.mod for a long time, if that's what you mean.

At the same time, if we're to do #2993, this won't be a problem, right?

I think yes.

[roman-khimov]

No, mapstructure is a part of the viper package

But that was an indirect import while here it's a direct one.

I think we better handle panic here and leave the rest for #2993, it can be scheduled for the next release then.

[End-rey]

leave the rest for #2993

So, remove the check for unmarshalling?

[roman-khimov]

Yes.

[roman-khimov]

Changelog?