Update to the latest SDK #3023
Draft
Update to the latest SDK #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Make `Client` interface fit the SDK method: `ReplicateObject(ctx context.Context, id oid.ID, src io.ReadSeeker, signer neofscrypto.Signer, signedReplication bool) (*neofscrypto.Signature, error)`. Use `Action.DecodeString` instead of `eacl.ActionFromString`. Use `Object.ReadFromV2` instead of `object.NewFromV2`. Use `Type.String` instead of `Type.EncodeToString`. Check some vars for nil. Signed-off-by: Andrey Butusov <[email protected]>
Use `GetAttributes` and `SetAttributes` from SDK instead of api-go `netmap.Attribute`. Signed-off-by: Andrey Butusov <[email protected]>
|
i'll notice here when SDK will be well-tested and rdy for a clean update, most likely https://github.com/nspcc-dev/neofs-sdk-go/milestone/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3005.
Wait for fixing SDK problems.