node: Respond with UNIMPLEMENTED status when RPC is not yet supported
#2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any time when protocol was extended, any NeoFS SDK upgrade led to compilation error caused by unimplemented interface method(s) added to the gRPC re-generated code. Embed `UnimplementedXServer` structure provided by the gRPC generated code into all implementation so missing methods would auto-respond with `UNIMPLEMENTED` status. Interface extensions won't be longer break the app compilation. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2752 +/- ##
==========================================
- Coverage 28.88% 28.87% -0.02%
==========================================
Files 415 415
Lines 32478 32478
==========================================
- Hits 9382 9378 -4
- Misses 22254 22257 +3
- Partials 842 843 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Feb 26, 2024
carpawell
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context