refactor/Object transformer package
#2671
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2671 +/- ##
=======================================
Coverage 30.09% 30.09%
=======================================
Files 406 406
Lines 30182 30182
=======================================
Hits 9083 9083
Misses 20319 20319
Partials 780 780 ☔ View full report in Codecov by Sentry. |
carpawell
force-pushed
the
rm/node-side-slicer
branch
from
46bb381 to
671038c
Compare
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
carpawell
force-pushed
the
rm/node-side-slicer
branch
from
671038c to
a5fbe5e
Compare
carpawell
force-pushed
the
rm/node-side-slicer
branch
from
a5fbe5e to
206c182
Compare
| @@ -4,7 +4,7 @@ import ( | |||
| "context" | |||
| "fmt" | |||
|
|
|||
| "github.com/nspcc-dev/neofs-node/pkg/services/object_manager/transformer" | |||
| "github.com/nspcc-dev/neofs-node/pkg/services/object/internal" | |||
There was a problem hiding this comment.
Usually, internal/smth is used, because internal itself doesn't mean a lot.
There was a problem hiding this comment.
can you suggest naming? object? target? objectarget?
There was a problem hiding this comment.
It's strange enough we have a whole package just for this interface. To me it looks a lot like a part of pkg/services/object/put. But there it'd be internal. But then who needs an internal interface?
There was a problem hiding this comment.
#2671 (comment) describes where i saw this interface and why
part of it is used by the get service too. i wanted to see more usages but somehow we have so many WriteChunk and Write(object.Object) error (not the oi.Writer) so it does not look so useful sadly. but we can continue this refactor
There was a problem hiding this comment.
get doesn't need it. It has the thing it needs already.
There was a problem hiding this comment.
dont you like how HeaderWriter is included in the Target and how every object interface can be placed in a single common file? every header should be written with the same interface does not matter what service does it
carpawell
force-pushed
the
rm/node-side-slicer
branch
from
206c182 to
34189e9
Compare
Not needed complication. Signed-off-by: Pavel Karpy <[email protected]>
It stores ID only (but it was not always like this) but complicate the interface. Signed-off-by: Pavel Karpy <[email protected]>
`transformer` package is not needed anymore; SDK's `Slicer` is responsible for the object payload limitations. Closes #2519. Signed-off-by: Pavel Karpy <[email protected]>
Also, reuse it in the get service. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
rm/node-side-slicer
branch
from
34189e9 to
d211e27
Compare
No description provided.