node: don't mkdir random paths from configuration #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
- Coverage 29.83% 29.83% -0.01%
==========================================
Files 406 406
Lines 31022 31026 +4
==========================================
Hits 9256 9256
- Misses 20955 20959 +4
Partials 811 811
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
force-pushed
the
dont-mkdir-peapods
branch
from
0f2a6a8 to
74dc2b3
Compare
roman-khimov
added a commit
to nspcc-dev/neofs-dev-env
that referenced
this pull request
Sep 13, 2023
Can't convert storage configuration to peapod now, nspcc-dev/neofs-node#2576 Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added a commit
to nspcc-dev/neofs-aio
that referenced
this pull request
Sep 13, 2023
Still using bbcz, see nspcc-dev/neofs-node#2576. Signed-off-by: Roman Khimov <[email protected]>
carpawell
approved these changes
Sep 13, 2023
roman-khimov
force-pushed
the
dont-mkdir-peapods
branch
from
74dc2b3 to
c75f18b
Compare
Unbreak peapods: 2023/09/13 18:50:36 open shard S4wpuCnzpWW7SbwhER3U1v: could not open *blobstor.BlobStor: open substorage peapod: open BoltDB instance: open /storage/peapod0.db: is a directory Call `stat()` gently instead walking up. FS mount point has to exist there in any event and we should have some access to it. The real problem is that #2462 (introducing Peapod) was correct on its own. And #2495 (introducing capacity) was also correct on its own. But they don't work together. Refs 7c54307. Refs c060b16. util.MkdirAllX will be removed from code in most of the cases. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
dont-mkdir-peapods
branch
from
c75f18b to
47bb163
Compare
roman-khimov
added a commit
to nspcc-dev/neofs-aio
that referenced
this pull request
Sep 14, 2023
Still using bbcz, see nspcc-dev/neofs-node#2576.
carpawell
approved these changes
Sep 14, 2023
cthulhu-rider
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbreak peapods:
2023/09/13 18:50:36 open shard S4wpuCnzpWW7SbwhER3U1v: could not open *blobstor.BlobStor: open substorage peapod: open BoltDB instance: open /storage/peapod0.db: is a directory
Call
stat()gently instead walking up. FS mount point has to exist there in any event and we should have some access to it.util.MkdirAllX will be removed from code in most of the cases.