Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR: morph.consensus.peers.min config defaults incorrectly #2424

Closed
cthulhu-rider opened this issue Jul 6, 2023 · 1 comment
Closed

IR: morph.consensus.peers.min config defaults incorrectly #2424

cthulhu-rider opened this issue Jul 6, 2023 · 1 comment
Labels
bug Something isn't working config Configuration format update or breaking change I4 No visible changes neofs-storage Storage node application issues S4 Routine U2 Seriously planned

Comments

@cthulhu-rider
Copy link
Contributor

seems like declared default behavior of

min: 1 # Optional minimum number of peers a node needs for normal operation. Defaults to consensus minimum
config doesn't work

when config key min is ommited, final used value must be calculated from committee array size. E.g. for 4 committee members min must default to 2

@cthulhu-rider cthulhu-rider added bug Something isn't working neofs-storage Storage node application issues config Configuration format update or breaking change labels Jul 6, 2023
@roman-khimov roman-khimov added U2 Seriously planned S4 Routine I4 No visible changes labels Dec 21, 2023
@cthulhu-rider
Copy link
Contributor Author

fixed by #2856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config Configuration format update or breaking change I4 No visible changes neofs-storage Storage node application issues S4 Routine U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants