Skip to content

Commit

Permalink
object/put: make iterateNodesForObject log object ID
Browse files Browse the repository at this point in the history
Signed-off-by: Pavel Karpy <[email protected]>
  • Loading branch information
carpawell committed Nov 25, 2024
1 parent 215189a commit 872baaf
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions pkg/services/object/put/distributed.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ func (x placementIterator) iterateNodesForObject(obj oid.ID, f func(nodeDesc) er
var err error
var nodeLists [][]netmap.NodeInfo
var replCounts []uint
var l = x.log.With(zap.Stringer("oid", obj))
if x.localOnly {
// TODO: although this particular case fits correctly into the general approach,
// much less actions can be done
Expand Down Expand Up @@ -288,7 +289,7 @@ func (x placementIterator) iterateNodesForObject(obj oid.ID, f func(nodeDesc) er
}
// critical error that may ultimately block the storage service. Normally it
// should not appear because entry into the network map under strict control
x.log.Error("failed to decode network endpoints of the storage node from the network map, skip the node",
l.Error("failed to decode network endpoints of the storage node from the network map, skip the node",
zap.String("public key", netmap.StringifyPublicKey(nodeLists[listInd][j])), zap.Error(nr.convertErr))
if listLen-nodesCounters[listInd].processed-1 < replRem { // -1 includes current node failure
err = fmt.Errorf("%w (last node error: failed to decode network addresses: %w)",
Expand Down Expand Up @@ -321,13 +322,13 @@ func (x placementIterator) iterateNodesForObject(obj oid.ID, f func(nodeDesc) er
processedNodesMtx.Unlock()
if err != nil {
lastRespErr.Store(err)
svcutil.LogServiceError(x.log, "PUT", nr.desc.info.AddressGroup(), err)
svcutil.LogServiceError(l, "PUT", nr.desc.info.AddressGroup(), err)
return
}
}); err != nil {
wg.Done()
err = fmt.Errorf("submit next job to save an object to the worker pool: %w", err)
svcutil.LogWorkerPoolError(x.log, "PUT", err)
svcutil.LogWorkerPoolError(l, "PUT", err)
}
}
wg.Wait()
Expand Down Expand Up @@ -359,7 +360,7 @@ broadcast:
if nr.convertErr != nil {
// critical error that may ultimately block the storage service. Normally it
// should not appear because entry into the network map under strict control
x.log.Error("failed to decode network endpoints of the storage node from the network map, skip the node",
l.Error("failed to decode network endpoints of the storage node from the network map, skip the node",

Check warning on line 363 in pkg/services/object/put/distributed.go

View check run for this annotation

Codecov / codecov/patch

pkg/services/object/put/distributed.go#L363

Added line #L363 was not covered by tests
zap.String("public key", netmap.StringifyPublicKey(nodeLists[i][j])), zap.Error(nr.convertErr))
continue // to send as many replicas as possible
}
Expand All @@ -378,12 +379,12 @@ broadcast:
nodeResults[pks] = nr
processedNodesMtx.Unlock()
if err != nil {
svcutil.LogServiceError(x.log, "PUT (extra broadcast)", nr.desc.info.AddressGroup(), err)
svcutil.LogServiceError(l, "PUT (extra broadcast)", nr.desc.info.AddressGroup(), err)
return
}
}); err != nil {
wg.Done()
svcutil.LogWorkerPoolError(x.log, "PUT (extra broadcast)", err)
svcutil.LogWorkerPoolError(l, "PUT (extra broadcast)", err)

Check warning on line 387 in pkg/services/object/put/distributed.go

View check run for this annotation

Codecov / codecov/patch

pkg/services/object/put/distributed.go#L387

Added line #L387 was not covered by tests
break broadcast
}
}
Expand Down

0 comments on commit 872baaf

Please sign in to comment.